From f5e7b457731f57a8de132d21790fe90761d064ee Mon Sep 17 00:00:00 2001 From: mitaclaw <140017135+mitaclaw@users.noreply.github.com> Date: Thu, 8 Aug 2024 07:41:33 -0700 Subject: [PATCH] BranchWatchDialog: Listen For `clicked` Signal Rather Than `pressed` The latter signal was used by mistake, see PR #8263. --- Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp | 12 ++++++------ Source/Core/DolphinQt/Debugger/CodeWidget.cpp | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp b/Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp index 4ee474c5ee..88ce34a8d2 100644 --- a/Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp +++ b/Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp @@ -256,16 +256,16 @@ BranchWatchDialog::BranchWatchDialog(Core::System& system, Core::BranchWatch& br m_btn_start_pause->setCheckable(true); m_btn_clear_watch = new QPushButton(tr("Clear Branch Watch"), nullptr); - connect(m_btn_clear_watch, &QPushButton::pressed, this, &BranchWatchDialog::OnClearBranchWatch); + connect(m_btn_clear_watch, &QPushButton::clicked, this, &BranchWatchDialog::OnClearBranchWatch); m_btn_clear_watch->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding); m_btn_path_was_taken = new QPushButton(tr("Code Path Was Taken"), nullptr); - connect(m_btn_path_was_taken, &QPushButton::pressed, this, + connect(m_btn_path_was_taken, &QPushButton::clicked, this, &BranchWatchDialog::OnCodePathWasTaken); m_btn_path_was_taken->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding); m_btn_path_not_taken = new QPushButton(tr("Code Path Not Taken"), nullptr); - connect(m_btn_path_not_taken, &QPushButton::pressed, this, + connect(m_btn_path_not_taken, &QPushButton::clicked, this, &BranchWatchDialog::OnCodePathNotTaken); m_btn_path_not_taken->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding); @@ -388,17 +388,17 @@ BranchWatchDialog::BranchWatchDialog(Core::System& system, Core::BranchWatch& br { // Misc. Controls m_btn_was_overwritten = new QPushButton(tr("Branch Was Overwritten"), nullptr); - connect(m_btn_was_overwritten, &QPushButton::pressed, this, + connect(m_btn_was_overwritten, &QPushButton::clicked, this, &BranchWatchDialog::OnBranchWasOverwritten); m_btn_was_overwritten->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding); m_btn_not_overwritten = new QPushButton(tr("Branch Not Overwritten"), nullptr); - connect(m_btn_not_overwritten, &QPushButton::pressed, this, + connect(m_btn_not_overwritten, &QPushButton::clicked, this, &BranchWatchDialog::OnBranchNotOverwritten); m_btn_not_overwritten->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding); m_btn_wipe_recent_hits = new QPushButton(tr("Wipe Recent Hits"), nullptr); - connect(m_btn_wipe_recent_hits, &QPushButton::pressed, this, + connect(m_btn_wipe_recent_hits, &QPushButton::clicked, this, &BranchWatchDialog::OnWipeRecentHits); m_btn_wipe_recent_hits->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding); m_btn_wipe_recent_hits->setEnabled(false); diff --git a/Source/Core/DolphinQt/Debugger/CodeWidget.cpp b/Source/Core/DolphinQt/Debugger/CodeWidget.cpp index 36d3d92284..5c92975f39 100644 --- a/Source/Core/DolphinQt/Debugger/CodeWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/CodeWidget.cpp @@ -180,7 +180,7 @@ void CodeWidget::ConnectWidgets() }); connect(m_search_callstack, &QLineEdit::textChanged, this, &CodeWidget::UpdateCallstack); - connect(m_branch_watch, &QPushButton::pressed, this, &CodeWidget::OnBranchWatchDialog); + connect(m_branch_watch, &QPushButton::clicked, this, &CodeWidget::OnBranchWatchDialog); connect(m_symbols_list, &QListWidget::itemPressed, this, &CodeWidget::OnSelectSymbol); connect(m_callstack_list, &QListWidget::itemPressed, this, &CodeWidget::OnSelectCallstack);