Merge pull request #6052 from Ebola16/master

Update Readme.md and various fixes

CMake/DolphinCompileDefinitions.cmake

@@ -1,4 +1,4 @@
-# Add a C or C++ compile definitions to the current scope
+# Add C or C++ compile definitions to the current scope
 #
 # dolphin_compile_definitions(def [def ...] [DEBUG_ONLY | RELEASE_ONLY])
 #

Readme.md

@@ -43,6 +43,9 @@ Visual Studio 2017 is a hard requirement. Other compilers might be
 able to build Dolphin on Windows but have not been tested and are not
 recommended to be used. Git and Windows 10 SDK 10.0.15063.0 must be installed when building.
 
+The "Release" solution configuration includes performance optimizations for the best user experience but complicates debugging Dolphin.
+The "Debug" solution configuration is significantly slower, more verbose and less permissive but makes debugging Dolphin easier.
+
 An installer can be created by using the `Installer.nsi` script in the
 Installer directory. This will require the Nullsoft Scriptable Install System
 (NSIS) to be installed. Creating an installer is not necessary to run Dolphin
@@ -125,9 +128,9 @@ see where it's stored) if you don't plan to reinstall Dolphin.
 `Usage: Dolphin [-h] [-d] [-l] [-e <str>] [-b] [-V <str>] [-A <str>]`
 
 * -h, --help Show this help message
-* -d, --debugger Opens the debugger
-* -l, --logger Opens the logger
-* -e, --exec=<str> Loads the specified file (DOL,ELF,WAD,GCM,ISO)
+* -d, --debugger Show the debugger pane and additional View menu options
+* -l, --logger Open the logger
+* -e, --exec=<str> Load the specified file (DOL,ELF,WAD,GCM,ISO)
 * -b, --batch Exit Dolphin with emulator
 * -V, --video_backend=<str> Specify a video backend
 * -A, --audio_emulation=<str> Low level (LLE) or high level (HLE) audio

Source/Core/DolphinQt2/Config/Graphics/SoftwareRendererWidget.cpp

@@ -49,9 +49,9 @@ void SoftwareRendererWidget::CreateWidgets()
   auto* overlay_box = new QGroupBox(tr("Overlay Information"));
   auto* overlay_layout = new QGridLayout();
   overlay_box->setLayout(overlay_layout);
-  m_enable_statistics = new GraphicsBool(tr("Various Statistics"), Config::GFX_OVERLAY_STATS);
+  m_show_statistics = new GraphicsBool(tr("Show Statistics"), Config::GFX_OVERLAY_STATS);
 
-  overlay_layout->addWidget(m_enable_statistics);
+  overlay_layout->addWidget(m_show_statistics);
 
   auto* utility_box = new QGroupBox(tr("Utility"));
   auto* utility_layout = new QGridLayout();
@@ -162,6 +162,6 @@ void SoftwareRendererWidget::AddDescriptions()
                  "this unchecked.");
 
   AddDescription(m_backend_combo, TR_BACKEND_DESCRIPTION);
-  AddDescription(m_enable_statistics, TR_SHOW_STATISTICS_DESCRIPTION);
+  AddDescription(m_show_statistics, TR_SHOW_STATISTICS_DESCRIPTION);
   AddDescription(m_dump_textures, TR_DUMP_TEXTURES_DESCRIPTION);
 }

Source/Core/DolphinQt2/Config/Graphics/SoftwareRendererWidget.h

@@ -29,7 +29,7 @@ private:
   void AddDescriptions();
 
   QComboBox* m_backend_combo;
-  QCheckBox* m_enable_statistics;
+  QCheckBox* m_show_statistics;
   QCheckBox* m_dump_textures;
   QCheckBox* m_dump_objects;
   QCheckBox* m_dump_tev_stages;

Source/Core/DolphinWX/Config/WiiConfigPane.cpp

@@ -88,7 +88,7 @@ void WiiConfigPane::InitializeGUI()
                                       "(576i) for PAL games.\nMay not work for all games."));
   m_screensaver_checkbox->SetToolTip(_("Dims the screen after five minutes of inactivity."));
   m_system_language_choice->SetToolTip(_("Sets the Wii system language."));
-  m_sd_card_checkbox->SetToolTip(_("Saved to /Wii/sd.raw (default size is 128mb)"));
+  m_sd_card_checkbox->SetToolTip(_("Saved to /Wii/sd.raw (default size is 128mb)."));
   m_connect_keyboard_checkbox->SetToolTip(_("May cause slow down in Wii Menu and some games."));
   m_bt_wiimote_motor_checkbox->SetToolTip(_("Enables Wii Remote vibration."));
 

Source/Core/DolphinWX/SoftwareVideoConfigDialog.cpp

@@ -89,8 +89,8 @@ SoftwareVideoConfigDialog::SoftwareVideoConfigDialog(wxWindow* parent, const std
       group_info->Add(szr_info, 0, wxEXPAND | wxLEFT | wxRIGHT, space5);
       group_info->AddSpacer(space5);
 
-      szr_info->Add(new SettingCheckBox(page_general, _("Various Statistics"), "",
-                                        Config::GFX_OVERLAY_STATS));
+      szr_info->Add(
+          new SettingCheckBox(page_general, _("Show Statistics"), "", Config::GFX_OVERLAY_STATS));
     }
 
     // - utility

Source/Core/UICommon/CommandLineParse.cpp

@@ -95,7 +95,7 @@ std::unique_ptr<optparse::OptionParser> CreateParser(ParserOptions options)
     parser->add_option("-d", "--debugger")
         .action("store_true")
         .help("Show the debugger pane and additional View menu options");
-    parser->add_option("-l", "--logger").action("store_true").help("Opens the logger");
+    parser->add_option("-l", "--logger").action("store_true").help("Open the logger");
     parser->add_option("-b", "--batch").action("store_true").help("Exit Dolphin with emulation");
     parser->add_option("-c", "--confirm").action("store_true").help("Set Confirm on Stop");
   }