From f1dde9fee06554fc2637842771a7799732ef4c4e Mon Sep 17 00:00:00 2001 From: 8times9 <35514663+8times9@users.noreply.github.com> Date: Sat, 8 Jun 2019 13:34:58 -0500 Subject: [PATCH] Qt: Minor adjustments to graphics window descriptions --- .../Config/Graphics/AdvancedWidget.cpp | 26 +++++++++---------- .../Config/Graphics/EnhancementsWidget.cpp | 26 +++++++++---------- .../Config/Graphics/GeneralWidget.cpp | 22 ++++++++-------- .../DolphinQt/Config/Graphics/HacksWidget.cpp | 13 +++++----- 4 files changed, 43 insertions(+), 44 deletions(-) diff --git a/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp b/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp index 4b1eda0aa3..05a07341e6 100644 --- a/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp +++ b/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp @@ -93,7 +93,7 @@ void AdvancedWidget::CreateWidgets() m_enable_cropping = new GraphicsBool(tr("Crop"), Config::GFX_CROP); m_enable_prog_scan = new QCheckBox(tr("Enable Progressive Scan")); m_backend_multithreading = - new GraphicsBool(tr("Backend Multi-threading"), Config::GFX_BACKEND_MULTITHREADING); + new GraphicsBool(tr("Backend Multithreading"), Config::GFX_BACKEND_MULTITHREADING); misc_layout->addWidget(m_enable_cropping, 0, 0); misc_layout->addWidget(m_enable_prog_scan, 0, 1); @@ -160,8 +160,8 @@ void AdvancedWidget::AddDescriptions() static const char TR_SHOW_STATS_DESCRIPTION[] = QT_TR_NOOP("Shows various rendering statistics.\n\nIf unsure, leave this unchecked."); static const char TR_TEXTURE_FORMAT_DESCRIPTION[] = QT_TR_NOOP( - "Modifies textures to show the format they're encoded in. May require an emulation reset to " - "apply.\n\nIf unsure, leave this unchecked."); + "Modifies textures to show the format they're encoded in.\n\nMay require an emulation " + "reset to apply.\n\nIf unsure, leave this unchecked."); static const char TR_VALIDATION_LAYER_DESCRIPTION[] = QT_TR_NOOP("Enables validation of API calls made by the video backend, which may assist in " "debugging graphical issues.\n\nIf unsure, leave this unchecked."); @@ -171,9 +171,9 @@ void AdvancedWidget::AddDescriptions() static const char TR_LOAD_CUSTOM_TEXTURE_DESCRIPTION[] = QT_TR_NOOP( "Loads custom textures from User/Load/Textures//.\n\nIf unsure, leave this " "unchecked."); - static const char TR_CACHE_CUSTOM_TEXTURE_DESCRIPTION[] = - QT_TR_NOOP("Caches custom textures to system RAM on startup.\nThis can require exponentially " - "more RAM but fixes possible stuttering.\n\nIf unsure, leave this unchecked."); + static const char TR_CACHE_CUSTOM_TEXTURE_DESCRIPTION[] = QT_TR_NOOP( + "Caches custom textures to system RAM on startup.\n\nThis can require exponentially " + "more RAM but fixes possible stuttering.\n\nIf unsure, leave this unchecked."); static const char TR_DUMP_EFB_DESCRIPTION[] = QT_TR_NOOP( "Dumps the contents of EFB copies to User/Dump/Textures/.\n\nIf unsure, leave this " "unchecked."); @@ -182,7 +182,7 @@ void AdvancedWidget::AddDescriptions() "upscaling.\n\nIf unsure, leave this unchecked."); static const char TR_INTERNAL_RESOLUTION_FRAME_DUMPING_DESCRIPTION[] = QT_TR_NOOP( "Creates frame dumps and screenshots at the internal resolution of the renderer, rather than " - "the size of the window it is displayed within. If the aspect ratio is widescreen, the " + "the size of the window it is displayed within.\n\nIf the aspect ratio is widescreen, the " "output image will be scaled horizontally to preserve the vertical resolution.\n\nIf " "unsure, leave this unchecked."); #if defined(HAVE_FFMPEG) @@ -201,15 +201,15 @@ void AdvancedWidget::AddDescriptions() "Enables progressive scan if supported by the emulated software. Most games don't have " "any issue with this.\n\nIf unsure, leave this unchecked."); static const char TR_BACKEND_MULTITHREADING_DESCRIPTION[] = - QT_TR_NOOP("Enables multi-threaded command submission in backends where supported. Enabling " + QT_TR_NOOP("Enables multithreaded command submission in backends where supported. Enabling " "this option may result in a performance improvement on systems with more than " "two CPU cores. Currently, this is limited to the Vulkan backend.\n\nIf unsure, " "leave this checked."); - static const char TR_DEFER_EFB_ACCESS_INVALIDATION_DESCRIPTION[] = - QT_TR_NOOP("Defers invalidation of the EFB access cache until a GPU synchronization command " - "is executed. If disabled, the cache will be invalidated with every draw call. " - "May improve performance in some games which rely on CPU EFB Access at the cost " - "of stability.\n\nIf unsure, leave this unchecked."); + static const char TR_DEFER_EFB_ACCESS_INVALIDATION_DESCRIPTION[] = QT_TR_NOOP( + "Defers invalidation of the EFB access cache until a GPU synchronization command " + "is executed. If disabled, the cache will be invalidated with every draw call. " + "\n\nMay improve performance in some games which rely on CPU EFB Access at the cost " + "of stability.\n\nIf unsure, leave this unchecked."); #ifdef _WIN32 static const char TR_BORDERLESS_FULLSCREEN_DESCRIPTION[] = QT_TR_NOOP( diff --git a/Source/Core/DolphinQt/Config/Graphics/EnhancementsWidget.cpp b/Source/Core/DolphinQt/Config/Graphics/EnhancementsWidget.cpp index 1166214e39..de82d1be71 100644 --- a/Source/Core/DolphinQt/Config/Graphics/EnhancementsWidget.cpp +++ b/Source/Core/DolphinQt/Config/Graphics/EnhancementsWidget.cpp @@ -290,8 +290,8 @@ void EnhancementsWidget::SaveSettings() void EnhancementsWidget::AddDescriptions() { static const char TR_INTERNAL_RESOLUTION_DESCRIPTION[] = - QT_TR_NOOP("Controls the rendering resolution. A high resolution greatly improves visual " - "quality, but also greatly increases GPU load and can cause issues in " + QT_TR_NOOP("Controls the rendering resolution.\n\nA high resolution greatly improves " + "visual quality, but also greatly increases GPU load and can cause issues in " "certain games. Generally speaking, the lower the internal resolution, the " "better performance will be.\n\nIf unsure, select Native."); @@ -312,13 +312,13 @@ void EnhancementsWidget::AddDescriptions() static const char TR_SCALED_EFB_COPY_DESCRIPTION[] = QT_TR_NOOP("Greatly increases the quality of textures generated using render-to-texture " - "effects. Slightly increases GPU load and causes relatively few graphical issues. " - "Raising the internal resolution will improve the effect of this setting.\n\nIf " - "unsure, leave this checked."); + "effects.\n\nSlightly increases GPU load and causes relatively few graphical " + "issues. Raising the internal resolution will improve the effect of this setting. " + "\n\nIf unsure, leave this checked."); static const char TR_PER_PIXEL_LIGHTING_DESCRIPTION[] = QT_TR_NOOP( "Calculates lighting of 3D objects per-pixel rather than per-vertex, smoothing out the " - "appearance of lit polygons and making individual triangles less noticeable.\nRarely causes " - "slowdowns or graphical issues.\n\nIf unsure, leave this unchecked."); + "appearance of lit polygons and making individual triangles less noticeable.\n\nRarely " + "causes slowdowns or graphical issues.\n\nIf unsure, leave this unchecked."); static const char TR_WIDESCREEN_HACK_DESCRIPTION[] = QT_TR_NOOP( "Forces the game to output graphics for any aspect ratio. Use with \"Aspect Ratio\" set to " "\"Force 16:9\" to force 4:3-only games to run at 16:9.\n\nRarely produces good results and " @@ -330,11 +330,11 @@ void EnhancementsWidget::AddDescriptions() "emulation.\n\nIf unsure, leave this unchecked."); static const char TR_3D_MODE_DESCRIPTION[] = QT_TR_NOOP( "Selects the stereoscopic 3D mode. Stereoscopy allows a better feeling " - "of depth if the necessary hardware is present.\n\nSide-by-Side and Top-and-Bottom are " + "of depth if the necessary hardware is present. Heavily decreases " + "emulation speed and sometimes causes issues.\n\nSide-by-Side and Top-and-Bottom are " "used by most 3D TVs.\nAnaglyph is used for Red-Cyan colored glasses.\nHDMI 3D is " "used when the monitor supports 3D display resolutions.\nPassive is another type of 3D " - "used by some TVs.\n\nHeavily decreases " - "emulation speed and sometimes causes issues.\n\nIf unsure, select Off."); + "used by some TVs.\n\nIf unsure, select Off."); static const char TR_3D_DEPTH_DESCRIPTION[] = QT_TR_NOOP( "Controls the separation distance between the virtual cameras. \n\nA higher " "value creates a stronger feeling of depth while a lower value is more comfortable."); @@ -347,12 +347,12 @@ void EnhancementsWidget::AddDescriptions() "mode.\n\nIf unsure, leave this unchecked."); static const char TR_FORCE_24BIT_DESCRIPTION[] = QT_TR_NOOP("Forces the game to render the RGB color channels in 24-bit, thereby increasing " - "quality by reducing color banding. Has no impact on performance and causes " + "quality by reducing color banding.\n\nHas no impact on performance and causes " "few graphical issues.\n\nIf unsure, leave this checked."); static const char TR_FORCE_TEXTURE_FILTERING_DESCRIPTION[] = QT_TR_NOOP("Filters all textures, including any that the game explicitly set as " - "unfiltered.\nMay improve quality of certain textures in some games, but will " - "cause issues in others.\n\nIf unsure, leave this unchecked."); + "unfiltered.\n\nMay improve quality of certain textures in some games, but " + "will cause issues in others.\n\nIf unsure, leave this unchecked."); static const char TR_DISABLE_COPY_FILTER_DESCRIPTION[] = QT_TR_NOOP("Disables the blending of adjacent rows when copying the EFB. This is known in " "some games as \"deflickering\" or \"smoothing\". \n\nDisabling the filter has no " diff --git a/Source/Core/DolphinQt/Config/Graphics/GeneralWidget.cpp b/Source/Core/DolphinQt/Config/Graphics/GeneralWidget.cpp index 17950de346..d49ce8efe8 100644 --- a/Source/Core/DolphinQt/Config/Graphics/GeneralWidget.cpp +++ b/Source/Core/DolphinQt/Config/Graphics/GeneralWidget.cpp @@ -202,7 +202,7 @@ void GeneralWidget::AddDescriptions() "select the backend that is least problematic.\n\nIf unsure, select OpenGL."); #else static const char TR_BACKEND_DESCRIPTION[] = QT_TR_NOOP( - "Selects what graphics API to use internally.\n\nThe software renderer is extremely " + "Selects which graphics API to use internally.\n\nThe software renderer is extremely " "slow and only useful for debugging, so any of the other backends are " "recommended.\n\nIf unsure, select OpenGL."); #endif @@ -219,21 +219,21 @@ void GeneralWidget::AddDescriptions() QT_TR_NOOP("Uses the main Dolphin window for rendering rather than " "a separate render window.\n\nIf unsure, leave this unchecked."); static const char TR_ASPECT_RATIO_DESCRIPTION[] = QT_TR_NOOP( - "Selects what aspect ratio to use when rendering:\n\nAuto: Uses the native aspect " + "Selects which aspect ratio to use when rendering.\n\nAuto: Uses the native aspect " "ratio\nForce 16:9: Mimics an analog TV with a widescreen aspect ratio.\nForce 4:3: " "Mimics a standard 4:3 analog TV.\nStretch to Window: Stretches the picture to the " "window size.\n\nIf unsure, select Auto."); static const char TR_VSYNC_DESCRIPTION[] = - QT_TR_NOOP("Waits for vertical blanks in order to prevent tearing. Decreases performance if " - "emulation speed is below 100%.\n\nIf unsure, leave this unchecked."); + QT_TR_NOOP("Waits for vertical blanks in order to prevent tearing.\n\nDecreases performance " + "if emulation speed is below 100%.\n\nIf unsure, leave this unchecked."); static const char TR_SHOW_FPS_DESCRIPTION[] = QT_TR_NOOP("Shows the number of frames rendered per second as a measure of " "emulation speed.\n\nIf unsure, leave this unchecked."); static const char TR_SHOW_NETPLAY_PING_DESCRIPTION[] = - QT_TR_NOOP("Shows the players' maximum ping while playing on " + QT_TR_NOOP("Shows the player's maximum ping while playing on " "NetPlay.\n\nIf unsure, leave this unchecked."); static const char TR_LOG_RENDERTIME_DESCRIPTION[] = - QT_TR_NOOP("Logs the render time of every frame to User/Logs/render_time.txt. Use this " + QT_TR_NOOP("Logs the render time of every frame to User/Logs/render_time.txt.\n\nUse this " "feature when to measure the performance of Dolphin.\n\nIf " "unsure, leave this unchecked."); static const char TR_SHOW_NETPLAY_MESSAGES_DESCRIPTION[] = @@ -241,20 +241,20 @@ void GeneralWidget::AddDescriptions() "while playing NetPlay.\n\nIf unsure, leave this unchecked."); static const char TR_SHADER_COMPILE_SYNC_DESCRIPTION[] = QT_TR_NOOP("Ubershaders are never used. Stuttering will occur during shader " - "compilation, but GPU demands are low. Recommended for low-end hardware.\n\nIf " - "unsure, select this mode."); + "compilation, but GPU demands are low.\n\nRecommended for low-end hardware. " + "\n\nIf unsure, select this mode."); static const char TR_SHADER_COMPILE_SYNC_UBER_DESCRIPTION[] = QT_TR_NOOP( "Ubershaders will always be used. Provides a near stutter-free experience at the cost of " - "high GPU performance requirements. Only recommended for high-end systems."); + "high GPU performance requirements.\n\nOnly recommended for high-end systems."); static const char TR_SHADER_COMPILE_ASYNC_UBER_DESCRIPTION[] = QT_TR_NOOP("Ubershaders will be used to prevent stuttering during shader compilation, but " - "specialized shaders will be used when they will not cause stuttering. In the " + "specialized shaders will be used when they will not cause stuttering.\n\nIn the " "best case it eliminates shader compilation stuttering while having minimal " "performance impact, but results depend on video driver behavior."); static const char TR_SHADER_COMPILE_ASYNC_SKIP_DESCRIPTION[] = QT_TR_NOOP( "Prevents shader compilation stuttering by not rendering waiting objects. Can work in " "scenarios where Ubershaders doesn't, at the cost of introducing visual glitches and broken " - "effects. Not recommended, only use if the other options give poor results."); + "effects.\n\nNot recommended, only use if the other options give poor results."); static const char TR_SHADER_COMPILE_BEFORE_START_DESCRIPTION[] = QT_TR_NOOP("Waits for all shaders to finish compiling before starting a game. Enabling this " "option may reduce stuttering or hitching for a short time after the game is " diff --git a/Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp b/Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp index 11040d6354..319b7eb309 100644 --- a/Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp +++ b/Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp @@ -212,11 +212,11 @@ void HacksWidget::AddDescriptions() "RAM (and Texture)\n\nIf unsure, leave this checked."); static const char TR_DEFER_EFB_COPIES_DESCRIPTION[] = QT_TR_NOOP( "Waits until the game synchronizes with the emulated GPU before writing the contents of EFB " - "copies to RAM. Reduces the overhead of EFB RAM copies, providing a performance boost in " + "copies to RAM.\n\nReduces the overhead of EFB RAM copies, providing a performance boost in " "many games, at the risk of breaking those which do not safely synchronize with the " "emulated GPU.\n\nIf unsure, leave this checked."); static const char TR_ACCUARCY_DESCRIPTION[] = QT_TR_NOOP( - "Adjusts the accuracy at which the GPU receives texture updates from RAM.\n\n " + "Adjusts the accuracy at which the GPU receives texture updates from RAM.\n\n" "The \"Safe\" setting eliminates the likelihood of the GPU missing texture updates " "from RAM. Lower accuracies cause in-game text to appear garbled in certain " "games.\n\nIf unsure, select the rightmost value."); @@ -228,13 +228,12 @@ void HacksWidget::AddDescriptions() static const char TR_IMMEDIATE_XFB_DESCRIPTION[] = QT_TR_NOOP("Displays XFB copies as soon as they are created, instead of waiting for " - "scanout. Can cause graphical defects " - "in some games if the game doesn't expect all XFB copies to be displayed. " - "However, turning this setting on reduces latency." - "\n\nIf unsure, leave this unchecked."); + "scanout.\n\nCan cause graphical defects in some games if the game doesn't " + "expect all XFB copies to be displayed. However, turning this setting on reduces " + "latency.\n\nIf unsure, leave this unchecked."); static const char TR_GPU_DECODING_DESCRIPTION[] = - QT_TR_NOOP("Enables texture decoding using the GPU instead of the CPU. This may result in " + QT_TR_NOOP("Enables texture decoding using the GPU instead of the CPU.\n\nThis may result in " "performance gains in some scenarios, or on systems where the CPU is the " "bottleneck.\n\nIf unsure, leave this unchecked.");