ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

TextureCache: Remove deleted textures from bound_textures 

Fixes issue where vulkan might crash trying to bind a deleted
texture.
This commit is contained in:
Scott Mansell 2021-10-10 14:08:19 +13:00
parent d771bee0fe
commit edb66dab84
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Source/Core/VideoCommon/TextureCacheBase.cpp
View File

@ -2552,13 +2552,21 @@ TextureCacheBase::InvalidateTexture(TexAddrCache::iterator iter, bool discard_pe
for (size_t i = 0; i < bound_textures.size(); ++i) for (size_t i = 0; i < bound_textures.size(); ++i)
{ {
// If the entry is currently bound and tmem has it recorded as cached, keep it, but mark it as if (bound_textures[i] == entry)
// invalidated. This way it can still be used via tmem cache emulation, but nothing else.
// Spyro: A Hero's Tail is known for using such overwritten textures.
if (bound_textures[i] == entry && TMEM::IsCached(static_cast<u32>(i)))
{ {
bound_textures[i]->tmem_only = true; if (TMEM::IsCached(static_cast<u32>(i)))
return ++iter; {
// If the entry is currently bound and tmem has it recorded as cached, keep it, but mark it
// as invalidated. This way it can still be used via tmem cache emulation, but nothing else.
// Spyro: A Hero's Tail is known for using such overwritten textures.
bound_textures[i]->tmem_only = true;
return ++iter;
}
else
{
// Otherwise, delete the reference to it from bound_textures
bound_textures[i] = nullptr;
}
} }
} }