From 98add9faf0369b6a69c2d29d3d4cd90bbad02d65 Mon Sep 17 00:00:00 2001 From: Tillmann Karras Date: Sat, 21 Sep 2024 20:11:37 +0100 Subject: [PATCH 1/2] Sw/Rasterizer: fix two elder typos, AD 2009 --- Source/Core/VideoBackends/Software/Rasterizer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/VideoBackends/Software/Rasterizer.cpp b/Source/Core/VideoBackends/Software/Rasterizer.cpp index b27dc14c89..718f2778b9 100644 --- a/Source/Core/VideoBackends/Software/Rasterizer.cpp +++ b/Source/Core/VideoBackends/Software/Rasterizer.cpp @@ -330,7 +330,7 @@ static void DrawTriangleFrontFace(const OutputVertexData* v0, const OutputVertex // adapted from http://devmaster.net/posts/6145/advanced-rasterization - // 28.4 fixed-pou32 coordinates. rounded to nearest and adjusted to match hardware output + // 28.4 fixed-point coordinates. rounded to nearest and adjusted to match hardware output // could also take floor and adjust -8 const s32 Y1 = iround(16.0f * (v0->screenPosition.y - scissor.y_off)) - 9; const s32 Y2 = iround(16.0f * (v1->screenPosition.y - scissor.y_off)) - 9; @@ -349,7 +349,7 @@ static void DrawTriangleFrontFace(const OutputVertexData* v0, const OutputVertex const s32 DY23 = Y2 - Y3; const s32 DY31 = Y3 - Y1; - // Fixed-pos32 deltas + // Fixed-point deltas const s32 FDX12 = DX12 * 16; const s32 FDX23 = DX23 * 16; const s32 FDX31 = DX31 * 16; From 0a299a4e1e2d76d46b458bd5f07a3de42b53e688 Mon Sep 17 00:00:00 2001 From: Tillmann Karras Date: Sat, 21 Sep 2024 21:53:34 +0100 Subject: [PATCH 2/2] Sw/Tev: drop unused macro --- Source/Core/VideoBackends/Software/Tev.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/Source/Core/VideoBackends/Software/Tev.cpp b/Source/Core/VideoBackends/Software/Tev.cpp index 95a19ae7f1..674c545759 100644 --- a/Source/Core/VideoBackends/Software/Tev.cpp +++ b/Source/Core/VideoBackends/Software/Tev.cpp @@ -23,12 +23,6 @@ #include "VideoCommon/VideoConfig.h" #include "VideoCommon/XFMemory.h" -#ifdef _DEBUG -#define ALLOW_TEV_DUMPS 1 -#else -#define ALLOW_TEV_DUMPS 0 -#endif - static inline s16 Clamp255(s16 in) { return std::clamp(in, 0, 255);