ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9834 from AdmiralCurtiss/fastmem-reserve-region-linux 

MemArena: Keep fastmem memory region mapped on Linux to ensure nothing allocates within the fastmem space.
This commit is contained in:
JMC47 2022-02-28 12:46:34 -05:00 committed by GitHub
parent f65dc6d525 ffbe6cb21f
commit ea116fbbdf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/Common/MemArena.h
View File

@ -113,7 +113,13 @@ private:
void* m_address_VirtualAlloc2 = nullptr; void* m_address_VirtualAlloc2 = nullptr;
void* m_address_MapViewOfFile3 = nullptr; void* m_address_MapViewOfFile3 = nullptr;
#else #else
#ifdef ANDROID
int fd; int fd;
#else
int m_shm_fd;
void* m_reserved_region;
std::size_t m_reserved_region_size;
#endif
#endif #endif
}; };

37
Source/Core/Common/MemArenaUnix.cpp
View File

@ -28,30 +28,39 @@ MemArena::~MemArena() = default;
void MemArena::GrabSHMSegment(size_t size) void MemArena::GrabSHMSegment(size_t size)
{ {
const std::string file_name = "/dolphin-emu." + std::to_string(getpid()); const std::string file_name = "/dolphin-emu." + std::to_string(getpid());
fd = shm_open(file_name.c_str(), O_RDWR | O_CREAT | O_EXCL, 0600); m_shm_fd = shm_open(file_name.c_str(), O_RDWR | O_CREAT | O_EXCL, 0600);
if (fd == -1) if (m_shm_fd == -1)
{ {
ERROR_LOG_FMT(MEMMAP, "shm_open failed: {}", strerror(errno)); ERROR_LOG_FMT(MEMMAP, "shm_open failed: {}", strerror(errno));
return; return;
} }
shm_unlink(file_name.c_str()); shm_unlink(file_name.c_str());
if (ftruncate(fd, size) < 0) if (ftruncate(m_shm_fd, size) < 0)
ERROR_LOG_FMT(MEMMAP, "Failed to allocate low memory space"); ERROR_LOG_FMT(MEMMAP, "Failed to allocate low memory space");
} }
void MemArena::ReleaseSHMSegment() void MemArena::ReleaseSHMSegment()
{ {
close(fd); close(m_shm_fd);
} }
void* MemArena::CreateView(s64 offset, size_t size) void* MemArena::CreateView(s64 offset, size_t size)
{ {
return MapInMemoryRegion(offset, size, nullptr); void* retval = mmap(nullptr, size, PROT_READ | PROT_WRITE, MAP_SHARED, m_shm_fd, offset);
if (retval == MAP_FAILED)
{
NOTICE_LOG_FMT(MEMMAP, "mmap failed");
return nullptr;
}
else
{
return retval;
}
} }
void MemArena::ReleaseView(void* view, size_t size) void MemArena::ReleaseView(void* view, size_t size)
{ {
UnmapFromMemoryRegion(view, size); munmap(view, size);
} }
u8* MemArena::ReserveMemoryRegion(size_t memory_size) u8* MemArena::ReserveMemoryRegion(size_t memory_size)
@ -63,19 +72,23 @@ u8* MemArena::ReserveMemoryRegion(size_t memory_size)
PanicAlertFmt("Failed to map enough memory space: {}", LastStrerrorString()); PanicAlertFmt("Failed to map enough memory space: {}", LastStrerrorString());
return nullptr; return nullptr;
} }
munmap(base, memory_size); m_reserved_region = base;
m_reserved_region_size = memory_size;
return static_cast<u8*>(base); return static_cast<u8*>(base);
} }
void MemArena::ReleaseMemoryRegion() void MemArena::ReleaseMemoryRegion()
{ {
if (m_reserved_region)
{
munmap(m_reserved_region, m_reserved_region_size);
m_reserved_region = nullptr;
}
} }
void* MemArena::MapInMemoryRegion(s64 offset, size_t size, void* base) void* MemArena::MapInMemoryRegion(s64 offset, size_t size, void* base)
{ {
void* retval = mmap(base, size, PROT_READ | PROT_WRITE, void* retval = mmap(base, size, PROT_READ | PROT_WRITE, MAP_SHARED | MAP_FIXED, m_shm_fd, offset);
MAP_SHARED | ((base == nullptr) ? 0 : MAP_FIXED), fd, offset);
if (retval == MAP_FAILED) if (retval == MAP_FAILED)
{ {
NOTICE_LOG_FMT(MEMMAP, "mmap failed"); NOTICE_LOG_FMT(MEMMAP, "mmap failed");
@ -89,6 +102,8 @@ void* MemArena::MapInMemoryRegion(s64 offset, size_t size, void* base)
void MemArena::UnmapFromMemoryRegion(void* view, size_t size) void MemArena::UnmapFromMemoryRegion(void* view, size_t size)
{ {
munmap(view, size); void* retval = mmap(view, size, PROT_NONE, MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0);
if (retval == MAP_FAILED)
NOTICE_LOG_FMT(MEMMAP, "mmap failed");
} }
} // namespace Common } // namespace Common