ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BreakPoints: Use character literals for finding single characters 

The single character find overload is better suited over the one for
finding character sequences.
This commit is contained in:
Lioncash 2017-01-11 09:41:26 -05:00
parent 4e649c60c0
commit e97953130d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Source/Core/Core/PowerPC/BreakPoints.cpp
View File

@ -55,7 +55,7 @@ void BreakPoints::AddFromStrings(const TBreakPointsStr& bp_strings)
std::stringstream ss; std::stringstream ss;
ss << std::hex << bp_string; ss << std::hex << bp_string;
ss >> bp.address; ss >> bp.address;
bp.is_enabled = bp_string.find("n") != bp_string.npos; bp.is_enabled = bp_string.find('n') != bp_string.npos;
bp.is_temporary = false; bp.is_temporary = false;
Add(bp); Add(bp);
} }
@ -157,11 +157,11 @@ void MemChecks::AddFromStrings(const TMemChecksStr& mc_strings)
std::stringstream ss; std::stringstream ss;
ss << std::hex << mc_string; ss << std::hex << mc_string;
ss >> mc.start_address; ss >> mc.start_address;
mc.is_ranged = mc_string.find("n") != mc_string.npos; mc.is_ranged = mc_string.find('n') != mc_string.npos;
mc.is_break_on_read = mc_string.find("r") != mc_string.npos; mc.is_break_on_read = mc_string.find('r') != mc_string.npos;
mc.is_break_on_write = mc_string.find("w") != mc_string.npos; mc.is_break_on_write = mc_string.find('w') != mc_string.npos;
mc.log_on_hit = mc_string.find("l") != mc_string.npos; mc.log_on_hit = mc_string.find('l') != mc_string.npos;
mc.break_on_hit = mc_string.find("p") != mc_string.npos; mc.break_on_hit = mc_string.find('p') != mc_string.npos;
if (mc.is_ranged) if (mc.is_ranged)
ss >> mc.end_address; ss >> mc.end_address;
else else