ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #663 from moshekaplan/patch-1 

Prevent potential buffer overflow in sscanf
This commit is contained in:
Ryan Houdek 2014-07-23 10:00:49 -05:00
parent 008b907bf0 cd8b65bd8a
commit e91db62f1b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/DolphinWX/Android/ButtonManager.cpp
View File

@ -117,13 +117,13 @@ namespace ButtonManager
{ {
hasbind = true; hasbind = true;
type = BIND_AXIS; type = BIND_AXIS;
sscanf(value.c_str(), "Device '%[^\']'-Axis %d%c", dev, &bindnum, &modifier); sscanf(value.c_str(), "Device '%127[^\']'-Axis %d%c", dev, &bindnum, &modifier);
} }
else if (std::string::npos != value.find("Button")) else if (std::string::npos != value.find("Button"))
{ {
hasbind = true; hasbind = true;
type = BIND_BUTTON; type = BIND_BUTTON;
sscanf(value.c_str(), "Device '%[^\']'-Button %d", dev, &bindnum); sscanf(value.c_str(), "Device '%127[^\']'-Button %d", dev, &bindnum);
} }
if (hasbind) if (hasbind)
AddBind(std::string(dev), new sBind(padID, configTypes[a], type, bindnum, modifier == '-' ? -1.0f : 1.0f)); AddBind(std::string(dev), new sBind(padID, configTypes[a], type, bindnum, modifier == '-' ? -1.0f : 1.0f));