ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DSPHLE: add a few comments

This commit is contained in:
Tillmann Karras 2017-06-21 07:07:10 +01:00
parent b2a3827ecb
commit e504da6f04
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp
View File

@ -427,8 +427,8 @@ void ZeldaUCode::RunPendingCommands()
switch (command) switch (command)
{ {
case 0x00: case 0x00:
case 0x0A: case 0x0A: // not a NOP in the NTSC IPL ucode but seems unused
case 0x0B: case 0x0B: // not a NOP in both IPL ucodes but seems unused
case 0x0F: case 0x0F:
// NOP commands. Log anyway in case we encounter a new version // NOP commands. Log anyway in case we encounter a new version
// where these are not NOPs anymore. // where these are not NOPs anymore.
@ -595,6 +595,7 @@ void ZeldaUCode::SendCommandAck(CommandAck ack_type, u16 sync_value)
{ {
// The light protocol uses the address of the command handler in the // The light protocol uses the address of the command handler in the
// DSP code instead of the command id... go figure. // DSP code instead of the command id... go figure.
// FIXME: LLE returns a different value
sync_value = 2 * ((sync_value >> 8) & 0x7F) + 0x62; sync_value = 2 * ((sync_value >> 8) & 0x7F) + 0x62;
m_mail_handler.PushMail(0x80000000 | sync_value); m_mail_handler.PushMail(0x80000000 | sync_value);
} }
@ -848,6 +849,7 @@ struct ZeldaAudioRenderer::VPB
// Samples stored in MRAM at an arbitrary sample rate (resampling is // Samples stored in MRAM at an arbitrary sample rate (resampling is
// applied, unlike PCM16_FROM_MRAM_RAW). // applied, unlike PCM16_FROM_MRAM_RAW).
SRC_PCM16_FROM_MRAM = 33, SRC_PCM16_FROM_MRAM = 33,
// TODO: 2, 6
}; };
u16 samples_source_type; u16 samples_source_type;
@ -1437,8 +1439,8 @@ void ZeldaAudioRenderer::LoadInputSamples(MixingBuffer* buffer, VPB* vpb)
u16 pattern_offset = pattern_info.idx * PATTERN_SIZE; u16 pattern_offset = pattern_info.idx * PATTERN_SIZE;
s16* pattern = m_const_patterns.data() + pattern_offset; s16* pattern = m_const_patterns.data() + pattern_offset;
u32 pos = vpb->current_pos_frac << 6; // log2(PATTERN_SIZE) u32 pos = vpb->current_pos_frac << 6; // log2(PATTERN_SIZE)
u32 step = vpb->resampling_ratio << 5; u32 step = vpb->resampling_ratio << 5; // FIXME: ucode 24B22038 shifts by 6 (?)
for (size_t i = 0; i < buffer->size(); ++i) for (size_t i = 0; i < buffer->size(); ++i)
{ {