ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BranchWatchDialog: Improve Branch Was/Not Overwritten Buttons 

Giving a warning if these are used when not usable is bad UX.
This commit is contained in:
mitaclaw 2024-08-31 15:10:04 -07:00
parent f5e7b45773
commit e4500b5798
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp
View File

@ -644,11 +644,6 @@ void BranchWatchDialog::OnCodePathNotTaken()
void BranchWatchDialog::OnBranchWasOverwritten() void BranchWatchDialog::OnBranchWasOverwritten()
{ {
if (Core::GetState(m_system) == Core::State::Uninitialized)
{
ModalMessageBox::warning(this, tr("Error"), tr("Core is uninitialized."));
return;
}
{ {
const Core::CPUThreadGuard guard{m_system}; const Core::CPUThreadGuard guard{m_system};
m_table_model->OnBranchWasOverwritten(guard); m_table_model->OnBranchWasOverwritten(guard);
@ -659,11 +654,6 @@ void BranchWatchDialog::OnBranchWasOverwritten()
void BranchWatchDialog::OnBranchNotOverwritten() void BranchWatchDialog::OnBranchNotOverwritten()
{ {
if (Core::GetState(m_system) == Core::State::Uninitialized)
{
ModalMessageBox::warning(this, tr("Error"), tr("Core is uninitialized."));
return;
}
{ {
const Core::CPUThreadGuard guard{m_system}; const Core::CPUThreadGuard guard{m_system};
m_table_model->OnBranchNotOverwritten(guard); m_table_model->OnBranchNotOverwritten(guard);
@ -689,6 +679,8 @@ void BranchWatchDialog::OnTimeout() const
void BranchWatchDialog::OnEmulationStateChanged(Core::State new_state) const void BranchWatchDialog::OnEmulationStateChanged(Core::State new_state) const
{ {
m_btn_was_overwritten->setEnabled(new_state != Core::State::Uninitialized);
m_btn_not_overwritten->setEnabled(new_state != Core::State::Uninitialized);
if (TimerCondition(m_branch_watch, new_state)) if (TimerCondition(m_branch_watch, new_state))
m_timer->start(BRANCH_WATCH_TOOL_TIMER_DELAY_MS); m_timer->start(BRANCH_WATCH_TOOL_TIMER_DELAY_MS);
else if (m_timer->isActive()) else if (m_timer->isActive())