Merge pull request #5000 from lioncash/fwd

JitInterface: Convert includes into forward declarations where applicable

Source/Core/Core/Core.cpp

@@ -22,8 +22,8 @@
 #include "Common/CommonTypes.h"
 #include "Common/Flag.h"
 #include "Common/Logging/LogManager.h"
-#include "Common/MathUtil.h"
 #include "Common/MemoryUtil.h"
+#include "Common/MsgHandler.h"
 #include "Common/StringUtil.h"
 #include "Common/Thread.h"
 #include "Common/Timer.h"
@@ -41,16 +41,12 @@
 #include "Core/Boot/Boot.h"
 #include "Core/FifoPlayer/FifoPlayer.h"
 #include "Core/HLE/HLE.h"
-#include "Core/HW/AudioInterface.h"
 #include "Core/HW/CPU.h"
 #include "Core/HW/DSP.h"
 #include "Core/HW/EXI/EXI.h"
 #include "Core/HW/GCKeyboard.h"
 #include "Core/HW/GCPad.h"
-#include "Core/HW/GPFifo.h"
 #include "Core/HW/HW.h"
-#include "Core/HW/Memmap.h"
-#include "Core/HW/ProcessorInterface.h"
 #include "Core/HW/SystemTimers.h"
 #include "Core/HW/VideoInterface.h"
 #include "Core/HW/Wiimote.h"

Source/Core/Core/HW/DSP.cpp

@@ -25,6 +25,7 @@
 #include <memory>
 
 #include "AudioCommon/AudioCommon.h"
+#include "Common/ChunkFile.h"
 #include "Common/CommonTypes.h"
 #include "Common/MemoryUtil.h"
 #include "Core/ConfigManager.h"

Source/Core/Core/MemTools.cpp

@@ -2,21 +2,21 @@
 // Licensed under GPLv2+
 // Refer to the license.txt file included.
 
+#include "Core/MemTools.h"
+
 #include <cstdio>
+#include <cstdlib>
+#include <cstring>
 #include <vector>
 
 #include "Common/CommonFuncs.h"
 #include "Common/CommonTypes.h"
+#include "Common/MsgHandler.h"
 #include "Common/Thread.h"
 
-#include "Core/HW/Memmap.h"
 #include "Core/MachineContext.h"
-#include "Core/MemTools.h"
 #include "Core/PowerPC/JitInterface.h"
-#include "Core/PowerPC/PowerPC.h"
+
-#ifndef _M_GENERIC
-#include "Core/PowerPC/JitCommon/JitBase.h"
-#endif
 #ifdef __FreeBSD__
 #include <signal.h>
 #endif

Source/Core/Core/PowerPC/Interpreter/Interpreter_LoadStore.cpp

@@ -2,11 +2,12 @@
 // Licensed under GPLv2+
 // Refer to the license.txt file included.
 
+#include "Common/Assert.h"
 #include "Common/CommonTypes.h"
-#include "Common/MathUtil.h"
+#include "Common/Logging/Log.h"
+#include "Common/MsgHandler.h"
 
 #include "Core/ConfigManager.h"
-#include "Core/HW/DSP.h"
 #include "Core/PowerPC/Interpreter/Interpreter.h"
 #include "Core/PowerPC/Interpreter/Interpreter_FPUtils.h"
 #include "Core/PowerPC/JitInterface.h"

Source/Core/Core/PowerPC/Jit64/Jit.cpp

@@ -13,6 +13,7 @@
 #endif
 
 #include "Common/CommonTypes.h"
+#include "Common/FileUtil.h"
 #include "Common/Logging/Log.h"
 #include "Common/MemoryUtil.h"
 #include "Common/StringUtil.h"

Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp

@@ -6,15 +6,17 @@
 // Should give a very noticable speed boost to paired single heavy code.
 
 #include "Core/PowerPC/Jit64/Jit.h"
+
+#include "Common/Assert.h"
 #include "Common/BitSet.h"
 #include "Common/CommonTypes.h"
 #include "Common/MsgHandler.h"
 #include "Common/x64ABI.h"
 #include "Common/x64Emitter.h"
+
 #include "Core/ConfigManager.h"
 #include "Core/CoreTiming.h"
 #include "Core/HW/CPU.h"
-#include "Core/HW/DSP.h"
 #include "Core/HW/Memmap.h"
 #include "Core/PowerPC/Jit64/JitRegCache.h"
 #include "Core/PowerPC/Jit64Common/Jit64PowerPCState.h"

Source/Core/Core/PowerPC/JitArm64/JitArm64Cache.cpp

@@ -6,7 +6,6 @@
 #include "Common/CommonTypes.h"
 #include "Core/PowerPC/JitArm64/Jit.h"
 #include "Core/PowerPC/JitCommon/JitBase.h"
-#include "Core/PowerPC/JitInterface.h"
 
 JitArm64BlockCache::JitArm64BlockCache(JitBase& jit) : JitBaseBlockCache{jit}
 {

Source/Core/Core/PowerPC/JitArm64/JitArm64_Tables.cpp

@@ -4,9 +4,8 @@
 
 #include "Core/PowerPC/JitArm64/Jit.h"
 
+#include <cstring>
 #include "Core/PowerPC/Gekko.h"
-#include "Core/PowerPC/JitInterface.h"
-#include "Core/PowerPC/PPCAnalyst.h"
 #include "Core/PowerPC/PPCTables.h"
 
 // Should be moved in to the Jit class

Source/Core/Core/PowerPC/JitCommon/JitCache.cpp

@@ -18,9 +18,7 @@
 #include "Common/JitRegister.h"
 #include "Core/ConfigManager.h"
 #include "Core/Core.h"
-#include "Core/CoreTiming.h"
 #include "Core/PowerPC/JitCommon/JitBase.h"
-#include "Core/PowerPC/JitInterface.h"
 #include "Core/PowerPC/PowerPC.h"
 
 #ifdef _WIN32

Source/Core/Core/PowerPC/JitInterface.cpp

@@ -2,8 +2,11 @@
 // Licensed under GPLv2+
 // Refer to the license.txt file included.
 
+#include "Core/PowerPC/JitInterface.h"
+
 #include <algorithm>
 #include <cinttypes>
+#include <cstdio>
 #include <string>
 
 #ifdef _WIN32
@@ -12,10 +15,15 @@
 #include "Common/PerformanceCounter.h"
 #endif
 
+#include "Common/ChunkFile.h"
+#include "Common/CommonTypes.h"
+#include "Common/FileUtil.h"
+#include "Common/MsgHandler.h"
+
 #include "Core/Core.h"
+#include "Core/PowerPC/CPUCoreBase.h"
 #include "Core/PowerPC/CachedInterpreter/CachedInterpreter.h"
 #include "Core/PowerPC/JitCommon/JitBase.h"
-#include "Core/PowerPC/JitInterface.h"
 #include "Core/PowerPC/PPCSymbolDB.h"
 #include "Core/PowerPC/PowerPC.h"
 #include "Core/PowerPC/Profiler.h"

Source/Core/Core/PowerPC/JitInterface.h

@@ -5,10 +5,13 @@
 #pragma once
 
 #include <string>
-#include "Common/ChunkFile.h"
+
+#include "Common/CommonTypes.h"
 #include "Core/MachineContext.h"
-#include "Core/PowerPC/CPUCoreBase.h"
+
-#include "Core/PowerPC/Profiler.h"
+class CPUCoreBase;
+class PointerWrap;
+struct ProfileStats;
 
 namespace JitInterface
 {

Source/Core/Core/PowerPC/PPCTables.cpp

@@ -8,10 +8,13 @@
 #include <array>
 #include <cinttypes>
 #include <cstddef>
+#include <cstdio>
 #include <vector>
 
+#include "Common/Assert.h"
 #include "Common/CommonTypes.h"
 #include "Common/FileUtil.h"
+#include "Common/Logging/Log.h"
 #include "Common/StringUtil.h"
 
 #include "Core/PowerPC/Interpreter/Interpreter.h"

Source/Core/Core/PowerPC/PowerPC.cpp

@@ -4,6 +4,8 @@
 
 #include "Core/PowerPC/PowerPC.h"
 
+#include <cstring>
+
 #include "Common/Assert.h"
 #include "Common/ChunkFile.h"
 #include "Common/CommonTypes.h"

Source/Core/DolphinWX/Debugger/CodeWindow.cpp

@@ -26,6 +26,7 @@
 // clang-format on
 
 #include "Common/CommonTypes.h"
+#include "Common/Logging/Log.h"
 #include "Common/StringUtil.h"
 #include "Common/SymbolDB.h"
 #include "Core/ConfigManager.h"

Source/Core/DolphinWX/Debugger/CodeWindowFunctions.cpp

@@ -21,6 +21,7 @@
 #include "Common/CommonTypes.h"
 #include "Common/FileUtil.h"
 #include "Common/IniFile.h"
+#include "Common/MsgHandler.h"
 #include "Common/SymbolDB.h"
 
 #include "Core/Boot/Boot.h"