ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ExpressionParser: Avoid some miscellaneous copies 

Just some trivial copies that can be eliminated or turned into moves.
This commit is contained in:
Lioncash 2023-12-12 14:03:39 -05:00
parent a5bbeb721a
commit ded2d55438
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
View File

@ -248,7 +248,7 @@ ParseStatus Lexer::Tokenize(std::vector<Token>& tokens)
class ControlExpression : public Expression class ControlExpression : public Expression
{ {
public: public:
explicit ControlExpression(ControlQualifier qualifier) : m_qualifier(qualifier) {} explicit ControlExpression(ControlQualifier qualifier) : m_qualifier(std::move(qualifier)) {}
ControlState GetValue() const override ControlState GetValue() const override
{ {
@ -448,7 +448,7 @@ private:
const ControlState m_value{}; const ControlState m_value{};
}; };
static ParseResult MakeLiteralExpression(Token token) static ParseResult MakeLiteralExpression(const Token& token)
{ {
ControlState val{}; ControlState val{};
if (TryParse(token.data, &val)) if (TryParse(token.data, &val))
@ -460,7 +460,7 @@ static ParseResult MakeLiteralExpression(Token token)
class VariableExpression : public Expression class VariableExpression : public Expression
{ {
public: public:
explicit VariableExpression(std::string name) : m_name(name) {} explicit VariableExpression(std::string name) : m_name(std::move(name)) {}
ControlState GetValue() const override { return m_variable_ptr ? *m_variable_ptr : 0; } ControlState GetValue() const override { return m_variable_ptr ? *m_variable_ptr : 0; }