diff --git a/CMakeLists.txt b/CMakeLists.txt index 6f20c890b8..4c2600de65 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -706,7 +706,6 @@ else() add_subdirectory(Externals/libiconv-1.14) set(ICONV_LIBRARIES iconv) endif() -list(APPEND LIBS ${ICONV_LIBRARIES}) if(NOT ANDROID) find_package(HIDAPI) diff --git a/Source/Core/Common/CMakeLists.txt b/Source/Core/Common/CMakeLists.txt index 10e8cd39b8..4ef3af3ac5 100644 --- a/Source/Core/Common/CMakeLists.txt +++ b/Source/Core/Common/CMakeLists.txt @@ -44,12 +44,16 @@ add_library(common x64Emitter.cpp ) -target_link_libraries(common PUBLIC +target_link_libraries(common +PUBLIC ${CMAKE_THREAD_LIBS_INIT} ${CURL_LIBRARIES} enet ${MBEDTLS_LIBRARIES} ${VTUNE_LIBRARIES} + +PRIVATE + ${ICONV_LIBRARIES} ) if (APPLE) @@ -65,7 +69,6 @@ if(ANDROID) target_sources(common PRIVATE Logging/ConsoleListenerDroid.cpp ) - target_link_libraries(common PRIVATE iconv) elseif(WIN32) target_sources(common PRIVATE Logging/ConsoleListenerWin.cpp