From dbfb8408d9703e73aa94909e2492cfe3403a809a Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 11 Oct 2022 09:18:29 -0400 Subject: [PATCH] HW: Use unsigned indices in RegisterMMIO where applicable base is an unsigned variable, so we can make things little more consistent by making the loop index unsigned so we aren't doing bit arithmetic with signed types. MemoryInterface already does this, so we can leave it alone. No behavioral changes, just a consistency thing. --- Source/Core/Core/HW/DSP.cpp | 2 +- Source/Core/Core/HW/ProcessorInterface.cpp | 2 +- Source/Core/Core/HW/VideoInterface.cpp | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/Core/Core/HW/DSP.cpp b/Source/Core/Core/HW/DSP.cpp index 650c35e1d0..3952133748 100644 --- a/Source/Core/Core/HW/DSP.cpp +++ b/Source/Core/Core/HW/DSP.cpp @@ -453,7 +453,7 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base) MMIO::InvalidWrite()); // 32 bit reads/writes are a combination of two 16 bit accesses. - for (int i = 0; i < 0x1000; i += 4) + for (u32 i = 0; i < 0x1000; i += 4) { mmio->Register(base | i, MMIO::ReadToSmaller(mmio, base | i, base | (i + 2)), MMIO::WriteToSmaller(mmio, base | i, base | (i + 2))); diff --git a/Source/Core/Core/HW/ProcessorInterface.cpp b/Source/Core/Core/HW/ProcessorInterface.cpp index bf4cb29f17..37c10580bd 100644 --- a/Source/Core/Core/HW/ProcessorInterface.cpp +++ b/Source/Core/Core/HW/ProcessorInterface.cpp @@ -142,7 +142,7 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base) MMIO::InvalidWrite()); // 16 bit reads are based on 32 bit reads. - for (int i = 0; i < 0x1000; i += 4) + for (u32 i = 0; i < 0x1000; i += 4) { mmio->Register(base | i, MMIO::ReadToLarger(mmio, base | i, 16), MMIO::InvalidWrite()); diff --git a/Source/Core/Core/HW/VideoInterface.cpp b/Source/Core/Core/HW/VideoInterface.cpp index 6e7780857d..5cc8a174d2 100644 --- a/Source/Core/Core/HW/VideoInterface.cpp +++ b/Source/Core/Core/HW/VideoInterface.cpp @@ -433,7 +433,7 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base) })); // Map 8 bit reads (not writes) to 16 bit reads. - for (int i = 0; i < 0x1000; i += 2) + for (u32 i = 0; i < 0x1000; i += 2) { mmio->Register(base | i, MMIO::ReadToLarger(mmio, base | i, 8), MMIO::InvalidWrite()); mmio->Register(base | (i + 1), MMIO::ReadToLarger(mmio, base | i, 0), @@ -441,7 +441,7 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base) } // Map 32 bit reads and writes to 16 bit reads and writes. - for (int i = 0; i < 0x1000; i += 4) + for (u32 i = 0; i < 0x1000; i += 4) { mmio->Register(base | i, MMIO::ReadToSmaller(mmio, base | i, base | (i + 2)), MMIO::WriteToSmaller(mmio, base | i, base | (i + 2)));