From db8ced7e4e4724c38f148ee449c346e447dd3942 Mon Sep 17 00:00:00 2001 From: Pokechu22 Date: Thu, 11 Feb 2021 22:38:07 -0800 Subject: [PATCH] Add FogParam0::FloatValue and FogParam3::FloatValue This value will be used in the register description; so expose it in a way that can be re-used instead of calculating it in 2 places later. --- Source/Core/VideoCommon/BPMemory.cpp | 26 ++++++++++++++++---------- Source/Core/VideoCommon/BPMemory.h | 2 ++ 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/Source/Core/VideoCommon/BPMemory.cpp b/Source/Core/VideoCommon/BPMemory.cpp index cb510e9e6a..e3887327d3 100644 --- a/Source/Core/VideoCommon/BPMemory.cpp +++ b/Source/Core/VideoCommon/BPMemory.cpp @@ -47,16 +47,26 @@ bool FogParams::IsNaNCase() const return a.exp == 255 && c_proj_fsel.c_exp == 255; } +float FogParam0::FloatValue() const +{ + // scale mantissa from 11 to 23 bits + const u32 integral = (sign << 31) | (exp << 23) | (mant << 12); + return Common::BitCast(integral); +} + +float FogParam3::FloatValue() const +{ + // scale mantissa from 11 to 23 bits + const u32 integral = (c_sign << 31) | (c_exp << 23) | (c_mant << 12); + return Common::BitCast(integral); +} + float FogParams::GetA() const { if (IsNaNCase()) return 0.0f; - // scale mantissa from 11 to 23 bits - const u32 integral = (static_cast(a.sign) << 31) | (static_cast(a.exp) << 23) | - (static_cast(a.mant) << 12); - - return Common::BitCast(integral); + return a.FloatValue(); } float FogParams::GetC() const @@ -67,9 +77,5 @@ float FogParams::GetC() const return !a.sign && !c_proj_fsel.c_sign ? -inf : inf; } - // scale mantissa from 11 to 23 bits - const u32 integral = (c_proj_fsel.c_sign.Value() << 31) | (c_proj_fsel.c_exp.Value() << 23) | - (c_proj_fsel.c_mant.Value() << 12); - - return Common::BitCast(integral); + return c_proj_fsel.FloatValue(); } diff --git a/Source/Core/VideoCommon/BPMemory.h b/Source/Core/VideoCommon/BPMemory.h index 86cc11f7d8..f6d54a6e74 100644 --- a/Source/Core/VideoCommon/BPMemory.h +++ b/Source/Core/VideoCommon/BPMemory.h @@ -661,6 +661,7 @@ union FogParam0 BitField<19, 1, u32> sign; u32 hex; + float FloatValue() const; }; union FogParam3 @@ -673,6 +674,7 @@ union FogParam3 // backward exp, 7 - backward exp2 u32 hex; + float FloatValue() const; }; union FogRangeKElement