From d9b51f74be03ba449618bd3985e005b45e06e3fc Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 4 Jun 2015 14:06:22 -0400 Subject: [PATCH] Core: Pass several parameters by const reference --- Source/Core/Core/ARDecrypt.cpp | 2 +- Source/Core/Core/DSP/DSPEmitter.h | 6 +++--- Source/Core/Core/DSP/Jit/DSPJitUtil.cpp | 6 +++--- Source/Core/Core/GeckoCode.cpp | 2 +- Source/Core/Core/GeckoCode.h | 2 +- Source/Core/Core/HW/GCMemcard.cpp | 2 +- Source/Core/Core/HW/GCMemcard.h | 2 +- Source/Core/Core/PowerPC/Jit64/JitRegCache.cpp | 4 ++-- Source/Core/Core/PowerPC/Jit64/JitRegCache.h | 6 +++--- 9 files changed, 16 insertions(+), 16 deletions(-) diff --git a/Source/Core/Core/ARDecrypt.cpp b/Source/Core/Core/ARDecrypt.cpp index 70c515e337..b9bb235850 100644 --- a/Source/Core/Core/ARDecrypt.cpp +++ b/Source/Core/Core/ARDecrypt.cpp @@ -414,7 +414,7 @@ static int GetVal(const char *flt, char chr) return ret; } -static int alphatobin(u32 *dst, std::vector alpha, int size) +static int alphatobin(u32 *dst, const std::vector& alpha, int size) { int j = 0; int ret = 0; diff --git a/Source/Core/Core/DSP/DSPEmitter.h b/Source/Core/Core/DSP/DSPEmitter.h index 4639478d3a..a6738e2045 100644 --- a/Source/Core/Core/DSP/DSPEmitter.h +++ b/Source/Core/Core/DSP/DSPEmitter.h @@ -272,11 +272,11 @@ private: void round_long_acc(Gen::X64Reg long_acc = Gen::EAX); void set_long_acc(int _reg, Gen::X64Reg acc = Gen::EAX); void get_acc_h(int _reg, Gen::X64Reg acc = Gen::EAX, bool sign = true); - void set_acc_h(int _reg, Gen::OpArg arg = R(Gen::EAX)); + void set_acc_h(int _reg, const Gen::OpArg& arg = R(Gen::EAX)); void get_acc_m(int _reg, Gen::X64Reg acc = Gen::EAX, bool sign = true); - void set_acc_m(int _reg, Gen::OpArg arg = R(Gen::EAX)); + void set_acc_m(int _reg, const Gen::OpArg& arg = R(Gen::EAX)); void get_acc_l(int _reg, Gen::X64Reg acc = Gen::EAX, bool sign = true); - void set_acc_l(int _reg, Gen::OpArg arg = R(Gen::EAX)); + void set_acc_l(int _reg, const Gen::OpArg& arg = R(Gen::EAX)); void get_long_acx(int _reg, Gen::X64Reg acx = Gen::EAX); void get_ax_l(int _reg, Gen::X64Reg acx = Gen::EAX); void get_ax_h(int _reg, Gen::X64Reg acc = Gen::EAX); diff --git a/Source/Core/Core/DSP/Jit/DSPJitUtil.cpp b/Source/Core/Core/DSP/Jit/DSPJitUtil.cpp index 0ec62f9e95..64761455e3 100644 --- a/Source/Core/Core/DSP/Jit/DSPJitUtil.cpp +++ b/Source/Core/Core/DSP/Jit/DSPJitUtil.cpp @@ -763,7 +763,7 @@ void DSPEmitter::get_acc_l(int _reg, X64Reg acl, bool sign) gpr.readReg(_reg+DSP_REG_ACL0, acl, sign?SIGN:ZERO); } -void DSPEmitter::set_acc_l(int _reg, OpArg arg) +void DSPEmitter::set_acc_l(int _reg, const OpArg& arg) { // return g_dsp.r[DSP_REG_ACM0 + _reg]; gpr.writeReg(_reg+DSP_REG_ACL0,arg); @@ -777,7 +777,7 @@ void DSPEmitter::get_acc_m(int _reg, X64Reg acm, bool sign) } // In: s16 in AX -void DSPEmitter::set_acc_m(int _reg, OpArg arg) +void DSPEmitter::set_acc_m(int _reg, const OpArg& arg) { // return g_dsp.r.ac[_reg].m; gpr.writeReg(_reg+DSP_REG_ACM0,arg); @@ -791,7 +791,7 @@ void DSPEmitter::get_acc_h(int _reg, X64Reg ach, bool sign) } // In: s16 in AX -void DSPEmitter::set_acc_h(int _reg, OpArg arg) +void DSPEmitter::set_acc_h(int _reg, const OpArg& arg) { // return g_dsp.r[DSP_REG_ACM0 + _reg]; gpr.writeReg(_reg+DSP_REG_ACH0,arg); diff --git a/Source/Core/Core/GeckoCode.cpp b/Source/Core/Core/GeckoCode.cpp index 1ea285d5e2..77d9de7129 100644 --- a/Source/Core/Core/GeckoCode.cpp +++ b/Source/Core/Core/GeckoCode.cpp @@ -33,7 +33,7 @@ bool GeckoCode::Exist(u32 address, u32 data) const } // return true if the code is identical -bool GeckoCode::Compare(GeckoCode compare) const +bool GeckoCode::Compare(const GeckoCode& compare) const { if (codes.size() != compare.codes.size()) return false; diff --git a/Source/Core/Core/GeckoCode.h b/Source/Core/Core/GeckoCode.h index a84a3dd20b..cf3c34b61a 100644 --- a/Source/Core/Core/GeckoCode.h +++ b/Source/Core/Core/GeckoCode.h @@ -36,7 +36,7 @@ namespace Gecko bool enabled; bool user_defined; - bool Compare(GeckoCode compare) const; + bool Compare(const GeckoCode& compare) const; bool Exist(u32 address, u32 data) const; }; diff --git a/Source/Core/Core/HW/GCMemcard.cpp b/Source/Core/Core/HW/GCMemcard.cpp index fe6853eff1..0a95da67e1 100644 --- a/Source/Core/Core/HW/GCMemcard.cpp +++ b/Source/Core/Core/HW/GCMemcard.cpp @@ -347,7 +347,7 @@ u16 GCMemcard::GetFreeBlocks() const return BE16(CurrentBat->FreeBlocks); } -u8 GCMemcard::TitlePresent(DEntry d) const +u8 GCMemcard::TitlePresent(const DEntry& d) const { if (!m_valid) return DIRLEN; diff --git a/Source/Core/Core/HW/GCMemcard.h b/Source/Core/Core/HW/GCMemcard.h index 7a5c0ee92e..0b3fa41391 100644 --- a/Source/Core/Core/HW/GCMemcard.h +++ b/Source/Core/Core/HW/GCMemcard.h @@ -360,7 +360,7 @@ public: u16 GetFreeBlocks() const; // If title already on memcard returns index, otherwise returns -1 - u8 TitlePresent(DEntry d) const; + u8 TitlePresent(const DEntry& d) const; bool GCI_FileName(u8 index, std::string &filename) const; // DEntry functions, all take u8 index < DIRLEN (127) diff --git a/Source/Core/Core/PowerPC/Jit64/JitRegCache.cpp b/Source/Core/Core/PowerPC/Jit64/JitRegCache.cpp index af52a7c0a5..eda4c3dc78 100644 --- a/Source/Core/Core/PowerPC/Jit64/JitRegCache.cpp +++ b/Source/Core/Core/PowerPC/Jit64/JitRegCache.cpp @@ -347,7 +347,7 @@ void GPRRegCache::LoadRegister(size_t preg, X64Reg newLoc) emit->MOV(32, ::Gen::R(newLoc), regs[preg].location); } -void GPRRegCache::StoreRegister(size_t preg, OpArg newLoc) +void GPRRegCache::StoreRegister(size_t preg, const OpArg& newLoc) { emit->MOV(32, newLoc, regs[preg].location); } @@ -357,7 +357,7 @@ void FPURegCache::LoadRegister(size_t preg, X64Reg newLoc) emit->MOVAPD(newLoc, regs[preg].location); } -void FPURegCache::StoreRegister(size_t preg, OpArg newLoc) +void FPURegCache::StoreRegister(size_t preg, const OpArg& newLoc) { emit->MOVAPD(newLoc, regs[preg].location.GetSimpleReg()); } diff --git a/Source/Core/Core/PowerPC/Jit64/JitRegCache.h b/Source/Core/Core/PowerPC/Jit64/JitRegCache.h index 44d9319558..2c572c3585 100644 --- a/Source/Core/Core/PowerPC/Jit64/JitRegCache.h +++ b/Source/Core/Core/PowerPC/Jit64/JitRegCache.h @@ -90,7 +90,7 @@ public: //read only will not set dirty flag void BindToRegister(size_t preg, bool doLoad = true, bool makeDirty = true); void StoreFromRegister(size_t preg, FlushMode mode = FLUSH_ALL); - virtual void StoreRegister(size_t preg, Gen::OpArg newLoc) = 0; + virtual void StoreRegister(size_t preg, const Gen::OpArg& newLoc) = 0; virtual void LoadRegister(size_t preg, Gen::X64Reg newLoc) = 0; const Gen::OpArg &R(size_t preg) const @@ -159,7 +159,7 @@ public: class GPRRegCache : public RegCache { public: - void StoreRegister(size_t preg, Gen::OpArg newLoc) override; + void StoreRegister(size_t preg, const Gen::OpArg& newLoc) override; void LoadRegister(size_t preg, Gen::X64Reg newLoc) override; Gen::OpArg GetDefaultLocation(size_t reg) const override; const int* GetAllocationOrder(size_t& count) override; @@ -172,7 +172,7 @@ public: class FPURegCache : public RegCache { public: - void StoreRegister(size_t preg, Gen::OpArg newLoc) override; + void StoreRegister(size_t preg, const Gen::OpArg& newLoc) override; void LoadRegister(size_t preg, Gen::X64Reg newLoc) override; const int* GetAllocationOrder(size_t& count) override; Gen::OpArg GetDefaultLocation(size_t reg) const override;