ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

IOS/USB_KBD: Make IsKeyPressed() a non-virtual const member function 

No other class inherits the USB_KBD class, and this function doesn't
actually modify instance state, so it can be made a const member
function.
This commit is contained in:
Lioncash 2019-05-31 08:40:41 -04:00
parent bcdc5b5f7e
commit d89ea8bf41
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Source/Core/Core/IOS/USB/USB_KBD.cpp
View File

@ -219,13 +219,10 @@ IPCCommandResult USB_KBD::IOCtl(const IOCtlRequest& request)
return GetDefaultReply(IPC_SUCCESS); return GetDefaultReply(IPC_SUCCESS);
} }
bool USB_KBD::IsKeyPressed(int _Key) bool USB_KBD::IsKeyPressed(int key) const
{ {
#ifdef _WIN32 #ifdef _WIN32
if (GetAsyncKeyState(_Key) & 0x8000) return (GetAsyncKeyState(key) & 0x8000) != 0;
return true;
else
return false;
#else #else
// TODO: do it for non-Windows platforms // TODO: do it for non-Windows platforms
return false; return false;

2
Source/Core/Core/IOS/USB/USB_KBD.h
View File

@ -54,7 +54,7 @@ private:
std::array<bool, 256> m_OldKeyBuffer{}; std::array<bool, 256> m_OldKeyBuffer{};
u8 m_OldModifiers = 0; u8 m_OldModifiers = 0;
virtual bool IsKeyPressed(int _Key); bool IsKeyPressed(int key) const;
// This stuff should probably die // This stuff should probably die
enum enum