Merge pull request #12512 from JosJuice/assembler-dirty-flag

DolphinQt: Rework dirty flag handling in AssemblerWidget::TabTextForEditor
This commit is contained in:
Mai 2024-01-21 10:22:46 -05:00 committed by GitHub
commit d64705d691
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 12 deletions

View File

@ -698,21 +698,23 @@ void AssemblerWidget::OnTabChange(int index)
QString AssemblerWidget::TabTextForEditor(AsmEditor* editor, bool with_dirty) QString AssemblerWidget::TabTextForEditor(AsmEditor* editor, bool with_dirty)
{ {
ASSERT(editor != nullptr); ASSERT(editor != nullptr);
QString dirtyFlag = QStringLiteral();
if (editor->IsDirty() && with_dirty) QString result;
if (!editor->Path().isEmpty())
result = editor->EditorTitle();
else if (editor->EditorNum() == 0)
result = tr("New File");
else
result = tr("New File (%1)").arg(editor->EditorNum() + 1);
if (with_dirty && editor->IsDirty())
{ {
dirtyFlag = QStringLiteral(" *"); // i18n: This asterisk is added to the title of an editor to indicate that it has unsaved
// changes
result = tr("%1 *").arg(result);
} }
if (editor->Path().isEmpty()) return result;
{
if (editor->EditorNum() == 0)
{
return tr("New File%1").arg(dirtyFlag);
}
return tr("New File (%1)%2").arg(editor->EditorNum() + 1).arg(dirtyFlag);
}
return tr("%1%2").arg(editor->EditorTitle()).arg(dirtyFlag);
} }
AsmEditor* AssemblerWidget::GetEditor(int idx) AsmEditor* AssemblerWidget::GetEditor(int idx)