From d57c1cbe6cae31f349337e107cf758deb6baa182 Mon Sep 17 00:00:00 2001 From: iwubcode Date: Fri, 1 Dec 2023 13:48:26 -0600 Subject: [PATCH] Android / Core / DolphinQt: disable arbitrary mipmap detection by default, let the games that need it be enabled with a config option, there aren't many of them --- .../dolphinemu/features/settings/model/BooleanSetting.kt | 2 +- Source/Android/app/src/main/res/values/strings.xml | 2 +- Source/Core/Core/Config/GraphicsSettings.cpp | 2 +- Source/Core/DolphinQt/Config/Graphics/EnhancementsWidget.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.kt b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.kt index 2d2a0065b4..c2b210102f 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.kt +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.kt @@ -762,7 +762,7 @@ enum class BooleanSetting( Settings.FILE_GFX, Settings.SECTION_GFX_ENHANCEMENTS, "ArbitraryMipmapDetection", - true + false ), GFX_CC_CORRECT_COLOR_SPACE( Settings.FILE_GFX, diff --git a/Source/Android/app/src/main/res/values/strings.xml b/Source/Android/app/src/main/res/values/strings.xml index 9575ec0eb2..f60e25c730 100644 --- a/Source/Android/app/src/main/res/values/strings.xml +++ b/Source/Android/app/src/main/res/values/strings.xml @@ -222,7 +222,7 @@ Disable Copy Filter Disables the blending of adjacent rows when copying the EFB. This is known in some games as \"deflickering\" or \"smoothing\". Disabling the filter is usually safe, and may result in a sharper image. Arbitrary Mipmap Detection - Enables detection of arbitrary mipmaps, which some games use for special distance-based effects.\nMay have false positives that result in blurry textures at increased internal resolution, such as in games that use very low resolution mipmaps. Disabling this can also reduce stutter in games that frequently load new textures.\n\nIf unsure, leave this checked. + Enables detection of arbitrary mipmaps, which some games use for special distance-based effects.\nMay have false positives that result in blurry textures at increased internal resolution, such as in games that use very low resolution mipmaps. Disabling this can also reduce stutter in games that frequently load new textures.\n\nIf unsure, leave this unchecked. Color Correction Color Space Correct Color Space diff --git a/Source/Core/Core/Config/GraphicsSettings.cpp b/Source/Core/Core/Config/GraphicsSettings.cpp index 37466e63cb..747ecceb5b 100644 --- a/Source/Core/Core/Config/GraphicsSettings.cpp +++ b/Source/Core/Core/Config/GraphicsSettings.cpp @@ -135,7 +135,7 @@ const Info GFX_ENHANCE_FORCE_TRUE_COLOR{{System::GFX, "Enhancements", "For const Info GFX_ENHANCE_DISABLE_COPY_FILTER{{System::GFX, "Enhancements", "DisableCopyFilter"}, true}; const Info GFX_ENHANCE_ARBITRARY_MIPMAP_DETECTION{ - {System::GFX, "Enhancements", "ArbitraryMipmapDetection"}, true}; + {System::GFX, "Enhancements", "ArbitraryMipmapDetection"}, false}; const Info GFX_ENHANCE_ARBITRARY_MIPMAP_DETECTION_THRESHOLD{ {System::GFX, "Enhancements", "ArbitraryMipmapDetectionThreshold"}, 14.0f}; const Info GFX_ENHANCE_HDR_OUTPUT{{System::GFX, "Enhancements", "HDROutput"}, false}; diff --git a/Source/Core/DolphinQt/Config/Graphics/EnhancementsWidget.cpp b/Source/Core/DolphinQt/Config/Graphics/EnhancementsWidget.cpp index aa0e3d1d28..4b575c855f 100644 --- a/Source/Core/DolphinQt/Config/Graphics/EnhancementsWidget.cpp +++ b/Source/Core/DolphinQt/Config/Graphics/EnhancementsWidget.cpp @@ -607,7 +607,7 @@ void EnhancementsWidget::AddDescriptions() "resolution, such as in games that use very low resolution mipmaps. Disabling this can also " "reduce stutter in games that frequently load new textures. This feature is not compatible " "with GPU Texture Decoding.

If unsure, leave this " - "checked."); + "unchecked."); static const char TR_HDR_DESCRIPTION[] = QT_TR_NOOP( "Enables scRGB HDR output (if supported by your graphics backend and monitor)." " Fullscreen might be required."