From 89eb019788b039a996b4373d806f5e44f6736827 Mon Sep 17 00:00:00 2001 From: Michael Maltese Date: Tue, 2 May 2017 20:01:29 -0700 Subject: [PATCH] SignatureDB: fix prevented copy elision Clang warning: ``` Source/Core/Core/PowerPC/SignatureDB/SignatureDB.cpp:22:17: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] : m_handler(std::move(CreateFormatHandler(handler))) ^ Source/Core/Core/PowerPC/SignatureDB/SignatureDB.cpp:22:17: note: remove std::move call here : m_handler(std::move(CreateFormatHandler(handler))) ^~~~~~~~~~ ~ ``` --- Source/Core/Core/PowerPC/SignatureDB/SignatureDB.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Source/Core/Core/PowerPC/SignatureDB/SignatureDB.cpp b/Source/Core/Core/PowerPC/SignatureDB/SignatureDB.cpp index 762bd39a71..d9582d99de 100644 --- a/Source/Core/Core/PowerPC/SignatureDB/SignatureDB.cpp +++ b/Source/Core/Core/PowerPC/SignatureDB/SignatureDB.cpp @@ -18,8 +18,7 @@ #include "Core/PowerPC/SignatureDB/DSYSignatureDB.h" #include "Core/PowerPC/SignatureDB/MEGASignatureDB.h" -SignatureDB::SignatureDB(SignatureDB::HandlerType handler) - : m_handler(std::move(CreateFormatHandler(handler))) +SignatureDB::SignatureDB(SignatureDB::HandlerType handler) : m_handler(CreateFormatHandler(handler)) { }