ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clean out some old left-behind quantizer stuff in Jit64/Jit_LoadStorePaired.cpp and Jit64/Jit_SystemRegisters.cpp.

This commit is contained in:
Lioncash 2014-02-14 23:32:37 -05:00
parent 8e5067500b
commit d42e8817a0
2 changed files with 10 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
Source/Core/Core/PowerPC/Jit64/Jit_LoadStorePaired.cpp
View File

@ -14,18 +14,6 @@
const u8 GC_ALIGNED16(pbswapShuffle2x4[16]) = {3, 2, 1, 0, 7, 6, 5, 4, 8, 9, 10, 11, 12, 13, 14, 15};
//static u64 GC_ALIGNED16(temp64); // unused?
// TODO(ector): Improve 64-bit version
#if 0
static void WriteDual32(u64 value, u32 address)
{
MOV(32, M(&PC), Imm32(jit->js.compilerPC)); // Helps external systems know which instruction triggered the write
Memory::Write_U32((u32)(value >> 32), address);
Memory::Write_U32((u32)value, address + 4);
}
#endif
// The big problem is likely instructions that set the quantizers in the same block.
// We will have to break block after quantizers are written to.
void Jit64::psq_st(UGeckoInstruction inst)
@ -48,33 +36,6 @@ void Jit64::psq_st(UGeckoInstruction inst)
int a = inst.RA;
int s = inst.RS; // Fp numbers
const UGQR gqr(rSPR(SPR_GQR0 + inst.I));
#if 0
u16 store_gqr = gqr.Hex & 0xFFFF;
const EQuantizeType stType = static_cast<EQuantizeType>(gqr.ST_TYPE);
int stScale = gqr.ST_SCALE;
// Is this specialization still worth it? Let's keep it for now. It's probably
// not very risky since a game most likely wouldn't use the same code to process
// floats as integers (but you never know....).
if (stType == QUANTIZE_FLOAT)
{
if (gpr.R(a).IsImm() && !update && cpu_info.bSSSE3)
{
u32 addr = (u32)(gpr.R(a).offset + offset);
if (addr == 0xCC008000) {
// Writing to FIFO. Let's do fast method.
CVTPD2PS(XMM0, fpr.R(s));
PSHUFB(XMM0, M((void*)&pbswapShuffle2x4));
CALL((void*)asm_routines.fifoDirectWriteXmm64);
js.fifoBytesThisBlock += 8;
return;
}
}
}
#endif
gpr.FlushLockX(EAX, EDX);
gpr.FlushLockX(ECX);
if (update)
@ -120,8 +81,6 @@ void Jit64::psq_l(UGeckoInstruction inst)
return;
}
const UGQR gqr(rSPR(SPR_GQR0 + inst.I));
bool update = inst.OPCD == 57;
int offset = inst.SIMM_12;

32
Source/Core/Core/PowerPC/Jit64/Jit_SystemRegisters.cpp
View File

@ -19,7 +19,6 @@ void Jit64::mtspr(UGeckoInstruction inst)
switch (iIndex)
{
case SPR_DMAU:
case SPR_SPRG0:
@ -46,20 +45,9 @@ void Jit64::mtspr(UGeckoInstruction inst)
case SPR_GQR0 + 5:
case SPR_GQR0 + 6:
case SPR_GQR0 + 7:
// Prevent recompiler from compiling in old quantizer values.
// If the value changed, destroy all blocks using this quantizer
// This will create a little bit of block churn, but hopefully not too bad.
{
/*
MOV(32, R(EAX), M(&PowerPC::ppcState.spr[iIndex])); // Load old value
CMP(32, R(EAX), gpr.R(inst.RD));
FixupBranch skip_destroy = J_CC(CC_E, false);
int gqr = iIndex - SPR_GQR0;
ABI_CallFunctionC(ProtectFunction(&Jit64::DestroyBlocksWithFlag, 1), (u32)BLOCK_USE_GQR0 << gqr);
SetJumpTarget(skip_destroy);*/
}
// These are safe to do the easy way, see the bottom of this function.
break;
// TODO - break block if quantizers are written to.
default:
Default(inst);
return;
@ -276,40 +264,40 @@ void Jit64::crXXX(UGeckoInstruction inst)
// Compute combined bit
switch(inst.SUBOP10)
{
case 33: // crnor
case 33: // crnor
OR(8, R(EAX), R(ECX));
NOT(8, R(EAX));
break;
case 129: // crandc
case 129: // crandc
NOT(8, R(ECX));
AND(8, R(EAX), R(ECX));
break;
case 193: // crxor
case 193: // crxor
XOR(8, R(EAX), R(ECX));
break;
case 225: // crnand
case 225: // crnand
AND(8, R(EAX), R(ECX));
NOT(8, R(EAX));
break;
case 257: // crand
case 257: // crand
AND(8, R(EAX), R(ECX));
break;
case 289: // creqv
case 289: // creqv
XOR(8, R(EAX), R(ECX));
NOT(8, R(EAX));
break;
case 417: // crorc
case 417: // crorc
NOT(8, R(ECX));
OR(8, R(EAX), R(ECX));
break;
case 449: // cror
case 449: // cror
OR(8, R(EAX), R(ECX));
break;
}