diff --git a/Source/Core/Core/HotkeyManager.cpp b/Source/Core/Core/HotkeyManager.cpp index 8c897a32b3..db60003036 100644 --- a/Source/Core/Core/HotkeyManager.cpp +++ b/Source/Core/Core/HotkeyManager.cpp @@ -160,7 +160,7 @@ static_assert(NUM_HOTKEYS == hotkey_labels.size(), "Wrong count of hotkey_labels namespace HotkeyManagerEmu { -static u32 s_hotkeyDown[NUM_HOTKEY_GROUPS]; +static std::array s_hotkeyDown; static HotkeyStatus s_hotkey; static bool s_enabled; @@ -217,8 +217,7 @@ void Initialize() // load the saved controller config s_config.LoadConfig(true); - for (u32& key : s_hotkeyDown) - key = 0; + s_hotkeyDown = {}; s_enabled = true; } @@ -269,7 +268,7 @@ constexpr std::array groups_info = { HotkeyManager::HotkeyManager() { - for (int group = 0; group < NUM_HOTKEY_GROUPS; group++) + for (std::size_t group = 0; group < m_hotkey_groups.size(); group++) { m_hotkey_groups[group] = (m_keys[group] = new ControllerEmu::Buttons("Keys", groups_info[group].name)); @@ -294,7 +293,7 @@ std::string HotkeyManager::GetName() const void HotkeyManager::GetInput(HotkeyStatus* const kb) { const auto lock = GetStateLock(); - for (int group = 0; group < NUM_HOTKEY_GROUPS; group++) + for (std::size_t group = 0; group < groups_info.size(); group++) { const int group_count = (groups_info[group].last - groups_info[group].first) + 1; std::vector bitmasks(group_count); diff --git a/Source/Core/Core/HotkeyManager.h b/Source/Core/Core/HotkeyManager.h index 29ece35861..8505412d16 100644 --- a/Source/Core/Core/HotkeyManager.h +++ b/Source/Core/Core/HotkeyManager.h @@ -182,7 +182,7 @@ enum HotkeyGroup : int struct HotkeyStatus { - u32 button[NUM_HOTKEY_GROUPS]; + std::array button; s8 err; }; @@ -200,7 +200,7 @@ public: void LoadDefaults(const ControllerInterface& ciface) override; private: - ControllerEmu::Buttons* m_keys[NUM_HOTKEY_GROUPS]; + std::array m_keys; std::array m_hotkey_groups; };