ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10103 from AdmiralCurtiss/cheat-search-length-underflow 

Core/CheatSearch: Avoid length underflow on new search.
This commit is contained in:
Mai M 2021-09-19 16:09:43 -04:00 committed by GitHub
parent 31ca114721 bd92c29ef5
commit ca2589f7df
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Source/Core/Core/CheatSearch.cpp
View File

@ -212,9 +212,16 @@ Cheats::NewSearch(const std::vector<Cheats::MemoryRange>& memory_ranges,
for (const Cheats::MemoryRange& range : memory_ranges) for (const Cheats::MemoryRange& range : memory_ranges)
{ {
if (range.m_length < data_size)
continue;
const u32 increment_per_loop = aligned ? data_size : 1; const u32 increment_per_loop = aligned ? data_size : 1;
const u32 start_address = aligned ? Common::AlignUp(range.m_start, data_size) : range.m_start; const u32 start_address = aligned ? Common::AlignUp(range.m_start, data_size) : range.m_start;
const u64 aligned_length = range.m_length - (start_address - range.m_start); const u64 aligned_length = range.m_length - (start_address - range.m_start);
if (aligned_length < data_size)
continue;
const u64 length = aligned_length - (data_size - 1); const u64 length = aligned_length - (data_size - 1);
for (u64 i = 0; i < length; i += increment_per_loop) for (u64 i = 0; i < length; i += increment_per_loop)
{ {