From c71ccb548e9baea772e2e900e9eeeadca8ec5341 Mon Sep 17 00:00:00 2001 From: "Admiral H. Curtiss" Date: Tue, 23 Jul 2024 20:48:17 +0200 Subject: [PATCH] AchievementManager: Fix incorrect check on network request return value in FetchBadge() --- Source/Core/Core/AchievementManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Core/AchievementManager.cpp b/Source/Core/Core/AchievementManager.cpp index b669a445b1..932ca45656 100644 --- a/Source/Core/Core/AchievementManager.cpp +++ b/Source/Core/Core/AchievementManager.cpp @@ -1175,7 +1175,7 @@ void AchievementManager::FetchBadge(AchievementManager::Badge* badge, u32 badge_ } auto http_response = http_request.Get(api_request.url, USER_AGENT_HEADER, Common::HttpRequest::AllowedReturnCodes::All); - if (http_response.has_value() && http_response->size() <= 0) + if (!http_response.has_value() || http_response->empty()) { WARN_LOG_FMT(ACHIEVEMENTS, "RetroAchievements connection failed on image request.\n URL: {}",