ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12884 from Tilka/qt_this 

DolphinQt: fix some warnings
This commit is contained in:
Admiral H. Curtiss 2024-06-23 15:08:13 +02:00 committed by GitHub
parent a75c65bde2 8e7d11d1a1
commit c337ab6473
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 13 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/DolphinQt/Config/Mapping/MappingWindow.cpp
View File

@ -59,8 +59,6 @@
#include "InputCommon/ControllerInterface/CoreDevice.h" #include "InputCommon/ControllerInterface/CoreDevice.h"
#include "InputCommon/InputConfig.h" #include "InputCommon/InputConfig.h"
constexpr const char* PROFILES_DIR = "Profiles/";
MappingWindow::MappingWindow(QWidget* parent, Type type, int port_num) MappingWindow::MappingWindow(QWidget* parent, Type type, int port_num)
: QDialog(parent), m_port(port_num) : QDialog(parent), m_port(port_num)
{ {

18
Source/Core/DolphinQt/GameList/GameList.cpp
View File

@ -299,16 +299,14 @@ void GameList::MakeEmptyView()
size_policy.setRetainSizeWhenHidden(true); size_policy.setRetainSizeWhenHidden(true);
m_empty->setSizePolicy(size_policy); m_empty->setSizePolicy(size_policy);
connect(&Settings::Instance(), &Settings::GameListRefreshRequested, this, connect(&Settings::Instance(), &Settings::GameListRefreshRequested, this, [this, refreshing_msg] {
[this, refreshing_msg = refreshing_msg] { m_empty->setText(refreshing_msg);
m_empty->setText(refreshing_msg); m_empty->setEnabled(false);
m_empty->setEnabled(false); });
}); connect(&Settings::Instance(), &Settings::GameListRefreshCompleted, this, [this, empty_msg] {
connect(&Settings::Instance(), &Settings::GameListRefreshCompleted, this, m_empty->setText(empty_msg);
[this, empty_msg = empty_msg] { m_empty->setEnabled(true);
m_empty->setText(empty_msg); });
m_empty->setEnabled(true);
});
} }
void GameList::resizeEvent(QResizeEvent* event) void GameList::resizeEvent(QResizeEvent* event)

5
Source/Core/DolphinQt/Settings.cpp
View File

@ -354,11 +354,6 @@ void Settings::NotifyRefreshGameListComplete()
emit GameListRefreshCompleted(); emit GameListRefreshCompleted();
} }
void Settings::RefreshMetadata()
{
emit MetadataRefreshRequested();
}
void Settings::NotifyMetadataRefreshComplete() void Settings::NotifyMetadataRefreshComplete()
{ {
emit MetadataRefreshCompleted(); emit MetadataRefreshCompleted();

1
Source/Core/DolphinQt/Settings.h
View File

@ -104,7 +104,6 @@ public:
void RefreshGameList(); void RefreshGameList();
void NotifyRefreshGameListStarted(); void NotifyRefreshGameListStarted();
void NotifyRefreshGameListComplete(); void NotifyRefreshGameListComplete();
void RefreshMetadata();
void NotifyMetadataRefreshComplete(); void NotifyMetadataRefreshComplete();
void ReloadTitleDB(); void ReloadTitleDB();
bool IsAutoRefreshEnabled() const; bool IsAutoRefreshEnabled() const;

10
Source/Core/DolphinQt/Settings/InterfacePane.cpp
View File

@ -235,15 +235,15 @@ void InterfacePane::ConnectLayout()
connect(m_checkbox_use_builtin_title_database, &QCheckBox::toggled, &Settings::Instance(), connect(m_checkbox_use_builtin_title_database, &QCheckBox::toggled, &Settings::Instance(),
&Settings::GameListRefreshRequested); &Settings::GameListRefreshRequested);
connect(m_checkbox_use_covers, &QCheckBox::toggled, &Settings::Instance(), connect(m_checkbox_use_covers, &QCheckBox::toggled, &Settings::Instance(),
&Settings::RefreshMetadata); &Settings::MetadataRefreshRequested);
connect(m_checkbox_show_debugging_ui, &QCheckBox::toggled, &Settings::Instance(), connect(m_checkbox_show_debugging_ui, &QCheckBox::toggled, &Settings::Instance(),
&Settings::SetDebugModeEnabled); &Settings::SetDebugModeEnabled);
connect(m_combobox_theme, &QComboBox::currentIndexChanged, this, connect(m_combobox_theme, &QComboBox::currentIndexChanged, &Settings::Instance(),
[this](int index) { Settings::Instance().TriggerThemeChanged(); }); &Settings::ThemeChanged);
connect(m_combobox_userstyle, &QComboBox::currentIndexChanged, this, connect(m_combobox_userstyle, &QComboBox::currentIndexChanged, this,
&InterfacePane::OnUserStyleChanged); &InterfacePane::OnUserStyleChanged);
connect(m_combobox_language, &QComboBox::currentIndexChanged, this, connect(m_combobox_language, &QComboBox::currentIndexChanged, this,
[this]() { OnLanguageChanged(); }); &InterfacePane::OnLanguageChanged);
connect(m_checkbox_top_window, &QCheckBox::toggled, &Settings::Instance(), connect(m_checkbox_top_window, &QCheckBox::toggled, &Settings::Instance(),
&Settings::KeepWindowOnTopChanged); &Settings::KeepWindowOnTopChanged);
connect(m_radio_cursor_visible_movement, &ConfigRadioInt::OnSelected, &Settings::Instance(), connect(m_radio_cursor_visible_movement, &ConfigRadioInt::OnSelected, &Settings::Instance(),
@ -253,7 +253,7 @@ void InterfacePane::ConnectLayout()
connect(m_radio_cursor_visible_always, &ConfigRadioInt::OnSelected, &Settings::Instance(), connect(m_radio_cursor_visible_always, &ConfigRadioInt::OnSelected, &Settings::Instance(),
&Settings::CursorVisibilityChanged); &Settings::CursorVisibilityChanged);
connect(m_checkbox_lock_mouse, &QCheckBox::toggled, &Settings::Instance(), connect(m_checkbox_lock_mouse, &QCheckBox::toggled, &Settings::Instance(),
[this]() { Settings::Instance().LockCursorChanged(); }); &Settings::LockCursorChanged);
} }
void InterfacePane::UpdateShowDebuggingCheckbox() void InterfacePane::UpdateShowDebuggingCheckbox()