ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GeneralPane: Add BalloonTip to fallback region combobox

This commit is contained in:
Dentomologist 2024-04-25 20:52:07 -07:00
parent fa4803f38a
commit bfbc4c8cc7
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Source/Core/DolphinQt/Settings/GeneralPane.cpp
View File

@ -213,17 +213,11 @@ void GeneralPane::CreateFallbackRegion()
fallback_region_dropdown_layout->setFieldGrowthPolicy(QFormLayout::AllNonFixedFieldsGrow); fallback_region_dropdown_layout->setFieldGrowthPolicy(QFormLayout::AllNonFixedFieldsGrow);
fallback_region_group_layout->addLayout(fallback_region_dropdown_layout); fallback_region_group_layout->addLayout(fallback_region_dropdown_layout);
m_combobox_fallback_region = new QComboBox(this); m_combobox_fallback_region = new ToolTipComboBox();
fallback_region_dropdown_layout->addRow(tr("Fallback Region:"), m_combobox_fallback_region); fallback_region_dropdown_layout->addRow(tr("Fallback Region:"), m_combobox_fallback_region);
for (const QString& option : {tr("NTSC-J"), tr("NTSC-U"), tr("PAL"), tr("NTSC-K")}) for (const QString& option : {tr("NTSC-J"), tr("NTSC-U"), tr("PAL"), tr("NTSC-K")})
m_combobox_fallback_region->addItem(option); m_combobox_fallback_region->addItem(option);
auto* fallback_region_description =
new QLabel(tr("Dolphin will use this for titles whose region cannot be determined "
"automatically."));
fallback_region_description->setWordWrap(true);
fallback_region_group_layout->addWidget(fallback_region_description);
} }
#if defined(USE_ANALYTICS) && USE_ANALYTICS #if defined(USE_ANALYTICS) && USE_ANALYTICS
@ -429,6 +423,9 @@ void GeneralPane::AddDescriptions()
"<br><br>Selecting \"Don't Update\" will prevent Dolphin from automatically checking for " "<br><br>Selecting \"Don't Update\" will prevent Dolphin from automatically checking for "
"updates." "updates."
"<br><br><dolphin_emphasis>If unsure, select Releases.</dolphin_emphasis>"); "<br><br><dolphin_emphasis>If unsure, select Releases.</dolphin_emphasis>");
static constexpr char TR_FALLBACK_REGION_DESCRIPTION[] =
QT_TR_NOOP("Sets the region used for titles whose region cannot be determined automatically."
"<br><br>This setting cannot be changed while emulation is active.");
m_checkbox_dualcore->SetDescription(tr(TR_DUALCORE_DESCRIPTION)); m_checkbox_dualcore->SetDescription(tr(TR_DUALCORE_DESCRIPTION));
@ -450,4 +447,7 @@ void GeneralPane::AddDescriptions()
m_combobox_update_track->SetTitle(tr("Auto Update")); m_combobox_update_track->SetTitle(tr("Auto Update"));
m_combobox_update_track->SetDescription(tr(TR_UPDATE_TRACK_DESCRIPTION)); m_combobox_update_track->SetDescription(tr(TR_UPDATE_TRACK_DESCRIPTION));
} }
m_combobox_fallback_region->SetTitle(tr("Fallback Region"));
m_combobox_fallback_region->SetDescription(tr(TR_FALLBACK_REGION_DESCRIPTION));
} }

2
Source/Core/DolphinQt/Settings/GeneralPane.h
View File

@ -43,7 +43,7 @@ private:
QVBoxLayout* m_main_layout; QVBoxLayout* m_main_layout;
ToolTipComboBox* m_combobox_speedlimit; ToolTipComboBox* m_combobox_speedlimit;
ToolTipComboBox* m_combobox_update_track; ToolTipComboBox* m_combobox_update_track;
QComboBox* m_combobox_fallback_region; ToolTipComboBox* m_combobox_fallback_region;
ConfigBool* m_checkbox_dualcore; ConfigBool* m_checkbox_dualcore;
ConfigBool* m_checkbox_cheats; ConfigBool* m_checkbox_cheats;
ConfigBool* m_checkbox_override_region_settings; ConfigBool* m_checkbox_override_region_settings;