diff --git a/Source/Core/DolphinQt/Config/Mapping/IOWindow.cpp b/Source/Core/DolphinQt/Config/Mapping/IOWindow.cpp index 0deb4f5293..659b6a889f 100644 --- a/Source/Core/DolphinQt/Config/Mapping/IOWindow.cpp +++ b/Source/Core/DolphinQt/Config/Mapping/IOWindow.cpp @@ -509,15 +509,17 @@ void IOWindow::OnDialogButtonPressed(QAbstractButton* button) const auto lock = ControllerEmu::EmulatedController::GetStateLock(); UpdateExpression(m_expression_text->toPlainText().toStdString()); - m_original_expression = m_reference->GetExpression(); if (ciface::ExpressionParser::ParseStatus::SyntaxError == m_reference->GetParseStatus()) { ModalMessageBox::warning(this, tr("Error"), tr("The expression contains a syntax error.")); } - - // must be the OK button - accept(); + else + { + // must be the OK button + m_original_expression = m_reference->GetExpression(); + accept(); + } } void IOWindow::OnDetectButtonPressed()