Merge pull request #5124 from leoetlino/more-accurate-import

IOS/ES: Handle imports more accurately

Source/Core/Core/IOS/ES/ES.cpp

@@ -18,6 +18,7 @@
 #include "Core/ConfigManager.h"
 #include "Core/HW/Memmap.h"
 #include "Core/IOS/ES/Formats.h"
+#include "Core/IOS/ES/NandUtils.h"
 #include "DiscIO/NANDContentLoader.h"
 
 namespace IOS
@@ -37,11 +38,29 @@ ES::ES(u32 device_id, const std::string& device_name) : Device(device_id, device
 {
 }
 
-void ES::Init()
+static void FinishAllStaleImports()
 {
+  const std::vector<u64> titles = IOS::ES::GetTitleImports();
+  for (const u64& title_id : titles)
+  {
+    const IOS::ES::TMDReader tmd = IOS::ES::FindImportTMD(title_id);
+    if (!tmd.IsValid())
+    {
+      File::DeleteDirRecursively(Common::GetImportTitlePath(title_id) + "/content");
+      continue;
+    }
+
+    FinishImport(tmd);
+  }
+
   const std::string import_dir = Common::RootUserPath(Common::FROM_SESSION_ROOT) + "/import";
   File::DeleteDirRecursively(import_dir);
   File::CreateDir(import_dir);
+}
+
+void ES::Init()
+{
+  FinishAllStaleImports();
 
   s_content_file = "";
   s_title_context = TitleContext{};

Source/Core/Core/IOS/ES/NandUtils.cpp

@@ -4,8 +4,10 @@
 
 #include <algorithm>
 #include <cctype>
+#include <cinttypes>
 #include <iterator>
 #include <string>
+#include <unordered_set>
 #include <vector>
 
 #include "Common/CommonTypes.h"
@@ -160,5 +162,84 @@ std::vector<Content> GetStoredContentsFromTMD(const TMDReader& tmd)
 
   return stored_contents;
 }
+
+bool InitImport(u64 title_id)
+{
+  const std::string content_dir = Common::GetTitleContentPath(title_id, Common::FROM_SESSION_ROOT);
+  const std::string data_dir = Common::GetTitleDataPath(title_id, Common::FROM_SESSION_ROOT);
+  for (const auto& dir : {content_dir, data_dir})
+  {
+    if (!File::IsDirectory(dir) && !File::CreateFullPath(dir) && !File::CreateDir(dir))
+    {
+      ERROR_LOG(IOS_ES, "InitImport: Failed to create title dirs for %016" PRIx64, title_id);
+      return false;
+    }
+  }
+
+  UIDSys uid_sys{Common::FROM_CONFIGURED_ROOT};
+  uid_sys.AddTitle(title_id);
+
+  // IOS moves the title content directory to /import if the TMD exists during an import.
+  if (File::Exists(Common::GetTMDFileName(title_id, Common::FROM_SESSION_ROOT)))
+  {
+    const std::string import_content_dir = Common::GetImportTitlePath(title_id) + "/content";
+    File::CreateFullPath(import_content_dir);
+    if (!File::Rename(content_dir, import_content_dir))
+    {
+      ERROR_LOG(IOS_ES, "InitImport: Failed to move content dir for %016" PRIx64, title_id);
+      return false;
+    }
+  }
+
+  return true;
+}
+
+bool FinishImport(const IOS::ES::TMDReader& tmd)
+{
+  const u64 title_id = tmd.GetTitleId();
+  const std::string import_content_dir = Common::GetImportTitlePath(title_id) + "/content";
+
+  // Remove everything not listed in the TMD.
+  std::unordered_set<std::string> expected_entries = {"title.tmd"};
+  for (const auto& content_info : tmd.GetContents())
+    expected_entries.insert(StringFromFormat("%08x.app", content_info.id));
+  const auto entries = File::ScanDirectoryTree(import_content_dir, false);
+  for (const File::FSTEntry& entry : entries.children)
+  {
+    // There should not be any directory in there. Remove it.
+    if (entry.isDirectory)
+      File::DeleteDirRecursively(entry.physicalName);
+    else if (expected_entries.find(entry.virtualName) == expected_entries.end())
+      File::Delete(entry.physicalName);
+  }
+
+  const std::string content_dir = Common::GetTitleContentPath(title_id, Common::FROM_SESSION_ROOT);
+  if (File::IsDirectory(content_dir))
+  {
+    WARN_LOG(IOS_ES, "FinishImport: %s already exists -- removing", content_dir.c_str());
+    File::DeleteDirRecursively(content_dir);
+  }
+  if (!File::Rename(import_content_dir, content_dir))
+  {
+    ERROR_LOG(IOS_ES, "FinishImport: Failed to rename import directory to %s", content_dir.c_str());
+    return false;
+  }
+  return true;
+}
+
+bool WriteImportTMD(const IOS::ES::TMDReader& tmd)
+{
+  const std::string tmd_path = Common::RootUserPath(Common::FROM_SESSION_ROOT) + "/tmp/title.tmd";
+  File::CreateFullPath(tmd_path);
+
+  {
+    File::IOFile file(tmd_path, "wb");
+    if (!file.WriteBytes(tmd.GetRawTMD().data(), tmd.GetRawTMD().size()))
+      return false;
+  }
+
+  const std::string dest = Common::GetImportTitlePath(tmd.GetTitleId()) + "/content/title.tmd";
+  return File::Rename(tmd_path, dest);
+}
 }  // namespace ES
 }  // namespace IOS

Source/Core/Core/IOS/ES/NandUtils.h

@@ -26,5 +26,12 @@ std::vector<u64> GetTitleImports();
 std::vector<u64> GetTitlesWithTickets();
 
 std::vector<Content> GetStoredContentsFromTMD(const TMDReader& tmd);
+
+// Start a title import.
+bool InitImport(u64 title_id);
+// Clean up the import content directory and move it back to /title.
+bool FinishImport(const IOS::ES::TMDReader& tmd);
+// Write a TMD for a title in /import atomically.
+bool WriteImportTMD(const IOS::ES::TMDReader& tmd);
 }  // namespace ES
 }  // namespace IOS

Source/Core/Core/IOS/ES/TitleManagement.cpp

@@ -66,28 +66,6 @@ IPCCommandResult ES::AddTicket(const IOCtlVRequest& request)
   return GetDefaultReply(IPC_SUCCESS);
 }
 
-static bool WriteImportTMD(const IOS::ES::TMDReader& tmd)
-{
-  const std::string tmd_path = Common::GetImportTitlePath(tmd.GetTitleId()) + "/content/title.tmd";
-  File::CreateFullPath(tmd_path);
-
-  File::IOFile file(tmd_path, "wb");
-  return file.WriteBytes(tmd.GetRawTMD().data(), tmd.GetRawTMD().size());
-}
-
-static bool MoveImportTMDToTitleDirectory(const IOS::ES::TMDReader& tmd)
-{
-  const std::string src = Common::GetImportTitlePath(tmd.GetTitleId()) + "/content/title.tmd";
-  const std::string dest = Common::GetTMDFileName(tmd.GetTitleId(), Common::FROM_SESSION_ROOT);
-  return File::RenameSync(src, dest);
-}
-
-static std::string GetImportContentPath(const IOS::ES::TMDReader& tmd, u32 content_id)
-{
-  return Common::GetImportTitlePath(tmd.GetTitleId()) +
-         StringFromFormat("/content/%08x.app", content_id);
-}
-
 IPCCommandResult ES::AddTMD(const IOCtlVRequest& request)
 {
   if (!request.HasNumberOfValidVectors(1, 0))
@@ -102,8 +80,8 @@ IPCCommandResult ES::AddTMD(const IOCtlVRequest& request)
   if (!m_addtitle_tmd.IsValid())
     return GetDefaultReply(ES_INVALID_TMD);
 
-  IOS::ES::UIDSys uid_sys{Common::FROM_CONFIGURED_ROOT};
+  if (!IOS::ES::InitImport(m_addtitle_tmd.GetTitleId()))
-  uid_sys.AddTitle(m_addtitle_tmd.GetTitleId());
+    return GetDefaultReply(FS_EIO);
 
   return GetDefaultReply(IPC_SUCCESS);
 }
@@ -124,8 +102,13 @@ IPCCommandResult ES::AddTitleStart(const IOCtlVRequest& request)
     return GetDefaultReply(ES_INVALID_TMD);
   }
 
-  IOS::ES::UIDSys uid_sys{Common::FROM_CONFIGURED_ROOT};
+  // Finish a previous import (if it exists).
-  uid_sys.AddTitle(m_addtitle_tmd.GetTitleId());
+  const IOS::ES::TMDReader previous_tmd = IOS::ES::FindImportTMD(m_addtitle_tmd.GetTitleId());
+  if (previous_tmd.IsValid())
+    FinishImport(previous_tmd);
+
+  if (!IOS::ES::InitImport(m_addtitle_tmd.GetTitleId()))
+    return GetDefaultReply(FS_EIO);
 
   // TODO: check and use the other vectors.
 
@@ -195,6 +178,11 @@ static bool CheckIfContentHashMatches(const std::vector<u8>& content, const IOS:
   return sha1 == info.sha1;
 }
 
+static std::string GetImportContentPath(u64 title_id, u32 content_id)
+{
+  return Common::GetImportTitlePath(title_id) + StringFromFormat("/content/%08x.app", content_id);
+}
+
 IPCCommandResult ES::AddContentFinish(const IOCtlVRequest& request)
 {
   if (!request.HasNumberOfValidVectors(1, 0))
@@ -238,46 +226,6 @@ IPCCommandResult ES::AddContentFinish(const IOCtlVRequest& request)
     return GetDefaultReply(ES_HASH_DOESNT_MATCH);
   }
 
-  // Just write all contents to the title import directory. AddTitleFinish will
-  // move the contents to the proper location.
-  const std::string tmp_path = GetImportContentPath(m_addtitle_tmd, m_addtitle_content_id);
-  File::CreateFullPath(tmp_path);
-
-  File::IOFile fp(tmp_path, "wb");
-  if (!fp.WriteBytes(decrypted_data.data(), content_info.size))
-  {
-    ERROR_LOG(IOS_ES, "AddContentFinish: Failed to write to %s", tmp_path.c_str());
-    return GetDefaultReply(ES_WRITE_FAILURE);
-  }
-
-  m_addtitle_content_id = 0xFFFFFFFF;
-  return GetDefaultReply(IPC_SUCCESS);
-}
-
-static void AbortImport(const u64 title_id, const std::vector<std::string>& processed_paths)
-{
-  for (const auto& path : processed_paths)
-    File::Delete(path);
-
-  const std::string import_dir = Common::GetImportTitlePath(title_id);
-  File::DeleteDirRecursively(import_dir);
-}
-
-IPCCommandResult ES::AddTitleFinish(const IOCtlVRequest& request)
-{
-  if (!request.HasNumberOfValidVectors(0, 0) || !m_addtitle_tmd.IsValid())
-    return GetDefaultReply(ES_PARAMETER_SIZE_OR_ALIGNMENT);
-
-  std::vector<std::string> processed_paths;
-
-  for (const auto& content_info : m_addtitle_tmd.GetContents())
-  {
-    const std::string source = GetImportContentPath(m_addtitle_tmd, content_info.id);
-
-    // Contents may not have been all imported. This is normal and this isn't an error condition.
-    if (!File::Exists(source))
-      continue;
-
   std::string content_path;
   if (content_info.IsShared())
   {
@@ -286,35 +234,44 @@ IPCCommandResult ES::AddTitleFinish(const IOCtlVRequest& request)
   }
   else
   {
-      content_path =
+    content_path = GetImportContentPath(m_addtitle_tmd.GetTitleId(), m_addtitle_content_id);
-          StringFromFormat("%s%08x.app", Common::GetTitleContentPath(m_addtitle_tmd.GetTitleId(),
-                                                                     Common::FROM_SESSION_ROOT)
-                                             .c_str(),
-                           content_info.id);
   }
-
   File::CreateFullPath(content_path);
-    if (!File::RenameSync(source, content_path))
+
+  const std::string temp_path = Common::RootUserPath(Common::FROM_SESSION_ROOT) +
+                                StringFromFormat("/tmp/%08x.app", m_addtitle_content_id);
+  File::CreateFullPath(temp_path);
+
   {
-      ERROR_LOG(IOS_ES, "AddTitleFinish: Failed to rename %s to %s", source.c_str(),
+    File::IOFile file(temp_path, "wb");
-                content_path.c_str());
+    if (!file.WriteBytes(decrypted_data.data(), content_info.size))
-      AbortImport(m_addtitle_tmd.GetTitleId(), processed_paths);
+    {
+      ERROR_LOG(IOS_ES, "AddContentFinish: Failed to write to %s", temp_path.c_str());
+      return GetDefaultReply(ES_WRITE_FAILURE);
+    }
+  }
+
+  if (!File::Rename(temp_path, content_path))
+  {
+    ERROR_LOG(IOS_ES, "AddContentFinish: Failed to move content to %s", content_path.c_str());
     return GetDefaultReply(ES_WRITE_FAILURE);
   }
 
-    // Do not delete shared contents even if the import fails. This is because
+  m_addtitle_content_id = 0xFFFFFFFF;
-    // they can be used by several titles and it's not safe to delete them.
+  return GetDefaultReply(IPC_SUCCESS);
-    //
-    // The reason we delete private contents is to avoid having a title with half-complete
-    // contents, as it can cause issues with the system menu. On the other hand, leaving
-    // shared contents does not cause any issue.
-    if (!content_info.IsShared())
-      processed_paths.push_back(content_path);
 }
 
-  if (!WriteImportTMD(m_addtitle_tmd) || !MoveImportTMDToTitleDirectory(m_addtitle_tmd))
+IPCCommandResult ES::AddTitleFinish(const IOCtlVRequest& request)
+{
+  if (!request.HasNumberOfValidVectors(0, 0) || !m_addtitle_tmd.IsValid())
+    return GetDefaultReply(ES_PARAMETER_SIZE_OR_ALIGNMENT);
+
+  if (!WriteImportTMD(m_addtitle_tmd))
     return GetDefaultReply(ES_WRITE_FAILURE);
 
+  if (!FinishImport(m_addtitle_tmd))
+    return GetDefaultReply(FS_EIO);
+
   INFO_LOG(IOS_ES, "IOCTL_ES_ADDTITLEFINISH");
   m_addtitle_tmd.SetBytes({});
   return GetDefaultReply(IPC_SUCCESS);
@@ -325,7 +282,17 @@ IPCCommandResult ES::AddTitleCancel(const IOCtlVRequest& request)
   if (!request.HasNumberOfValidVectors(0, 0) || !m_addtitle_tmd.IsValid())
     return GetDefaultReply(ES_PARAMETER_SIZE_OR_ALIGNMENT);
 
-  AbortImport(m_addtitle_tmd.GetTitleId(), {});
+  const IOS::ES::TMDReader original_tmd = IOS::ES::FindInstalledTMD(m_addtitle_tmd.GetTitleId());
+  if (!original_tmd.IsValid())
+  {
+    // This should never happen unless someone messed with the installed TMD directly.
+    // Still, let's check for this case and return an error instead of potentially crashing.
+    return GetDefaultReply(FS_ENOENT);
+  }
+
+  if (!FinishImport(original_tmd))
+    return GetDefaultReply(FS_EIO);
+
   m_addtitle_tmd.SetBytes({});
   return GetDefaultReply(IPC_SUCCESS);
 }