Merge pull request #2530 from Tilka/sdl_quit

SDL: handle SDL_QUIT event

Source/Core/Common/Common.h

@@ -136,6 +136,7 @@ enum HOST_COMM
 	WM_USER_STOP = 10,
 	WM_USER_CREATE,
 	WM_USER_SETCURSOR,
+	WM_USER_QUIT,
 };
 
 // Used for notification on emulation state

Source/Core/DolphinWX/Frame.cpp

@@ -778,6 +778,10 @@ void CFrame::OnHostMessage(wxCommandEvent& event)
 	case IDM_STOPPED:
 		OnStopped();
 		break;
+
+	case WM_USER_QUIT:
+		Close(true);
+		break;
 	}
 }
 

Source/Core/DolphinWX/MainNoGUI.cpp

@@ -49,7 +49,7 @@ void Host_RefreshDSPDebuggerWindow() {}
 static Common::Event updateMainFrameEvent;
 void Host_Message(int Id)
 {
-	if (Id == WM_USER_STOP)
+	if (Id == WM_USER_STOP || Id == WM_USER_QUIT)
 		running = false;
 }
 

Source/Core/InputCommon/ControllerInterface/ControllerInterface.cpp

@@ -134,6 +134,11 @@ void ControllerInterface::Shutdown()
 //
 void ControllerInterface::UpdateInput()
 {
+#ifdef CIFACE_USE_SDL
+	// SDL currently also handles SIGINT and SIGTERM,
+	// so make sure to update it even if there is no SDL device.
+	ciface::SDL::UpdateInput();
+#endif
 	for (ciface::Core::Device* d : m_devices)
 		d->UpdateInput();
 }

Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp

@@ -7,6 +7,7 @@
 #include <sstream>
 
 #include "Common/StringUtil.h"
+#include "Core/Host.h"
 #include "InputCommon/ControllerInterface/SDL/SDL.h"
 
 #ifdef _WIN32
@@ -67,6 +68,19 @@ void Init( std::vector<Core::Device*>& devices )
 	}
 }
 
+void UpdateInput()
+{
+	// Using SDL_INIT_JOYSTICK implies SDL_INIT_EVENT which installs a signal handler for SIGINT and SIGTERM.
+	// In the future, we will be able to prevent this from happening:
+	//     SDL_SetHint(SDL_HINT_NO_SIGNAL_HANDLERS, "1");
+	// but this was added after SDL 2.0.3 and is scheduled to be included in 2.0.4.
+	// Until then, handle SDL_QUIT events here and tell Dolphin to exit.
+	if (SDL_QuitRequested())
+		Host_Message(WM_USER_QUIT);
+
+	SDL_JoystickUpdate();
+}
+
 Joystick::Joystick(SDL_Joystick* const joystick, const int sdl_index, const unsigned int index)
 	: m_joystick(joystick)
 	, m_sdl_index(sdl_index)
@@ -283,12 +297,6 @@ void Joystick::LeftRightEffect::SetSDLHapticEffect(ControlState state)
 }
 #endif
 
-void Joystick::UpdateInput()
-{
-	// each joystick is doin this, o well
-	SDL_JoystickUpdate();
-}
-
 std::string Joystick::GetName() const
 {
 	return StripSpaces(GetJoystickName(m_sdl_index));

Source/Core/InputCommon/ControllerInterface/SDL/SDL.h

@@ -25,6 +25,7 @@ namespace SDL
 {
 
 void Init( std::vector<Core::Device*>& devices );
+void UpdateInput();
 
 class Joystick : public Core::Device
 {
@@ -130,8 +131,6 @@ private:
 #endif
 
 public:
-	void UpdateInput() override;
-
 	Joystick(SDL_Joystick* const joystick, const int sdl_index, const unsigned int index);
 	~Joystick();