ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

IniFile: std::move a std::string in GetLines 

Also gets rid of an unnecessary string copy.
This commit is contained in:
Lioncash 2017-03-22 19:09:22 -04:00
parent dbdf693c81
commit b92871111a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/Common/IniFile.cpp
View File

@ -274,13 +274,13 @@ void IniFile::Section::SetLines(std::vector<std::string>&& lines)
bool IniFile::Section::GetLines(std::vector<std::string>* lines, const bool remove_comments) const
{
for (std::string line : m_lines)
for (const std::string& line : m_lines)
{
line = StripSpaces(line);
std::string stripped_line = StripSpaces(line);
if (remove_comments)
{
size_t commentPos = line.find('#');
size_t commentPos = stripped_line.find('#');
if (commentPos == 0)
{
continue;
@ -288,11 +288,11 @@ bool IniFile::Section::GetLines(std::vector<std::string>* lines, const bool remo
if (commentPos != std::string::npos)
{
line = StripSpaces(line.substr(0, commentPos));
stripped_line = StripSpaces(stripped_line.substr(0, commentPos));
}
}
lines->push_back(line);
lines->push_back(std::move(stripped_line));
}
return true;