CodeViewWidget: Fix memory leak
Per https://doc.qt.io/qt-6/qabstractitemview.html#setItemDelegateForColumn setItemDelegateForColumn does not take ownership of the parameter, so it was not being deleted. Specifying a parent to QObject (via QStyledItemDelegate's constructor) will allow it to automatically be deleted, per https://doc.qt.io/qt-6/objecttrees.html. The other instance of a QItemDelegate in IOWindow.cpp already used this.
This commit is contained in:
parent
1c5e223532
commit
b6d476241a
|
@ -51,7 +51,7 @@ constexpr u32 WIDTH_PER_BRANCH_ARROW = 16;
|
|||
class BranchDisplayDelegate : public QStyledItemDelegate
|
||||
{
|
||||
public:
|
||||
BranchDisplayDelegate(CodeViewWidget* parent) : m_parent(parent) {}
|
||||
BranchDisplayDelegate(CodeViewWidget* parent) : QStyledItemDelegate(parent), m_parent(parent) {}
|
||||
|
||||
private:
|
||||
CodeViewWidget* m_parent;
|
||||
|
|
Loading…
Reference in New Issue