CodeViewWidget: Fix memory leak

Per https://doc.qt.io/qt-6/qabstractitemview.html#setItemDelegateForColumn setItemDelegateForColumn does not take ownership of the parameter, so it was not being deleted. Specifying a parent to QObject (via QStyledItemDelegate's constructor) will allow it to automatically be deleted, per https://doc.qt.io/qt-6/objecttrees.html. The other instance of a QItemDelegate in IOWindow.cpp already used this.
This commit is contained in:
Pokechu22 2023-02-17 18:20:50 -08:00
parent 1c5e223532
commit b6d476241a
1 changed files with 1 additions and 1 deletions

View File

@ -51,7 +51,7 @@ constexpr u32 WIDTH_PER_BRANCH_ARROW = 16;
class BranchDisplayDelegate : public QStyledItemDelegate class BranchDisplayDelegate : public QStyledItemDelegate
{ {
public: public:
BranchDisplayDelegate(CodeViewWidget* parent) : m_parent(parent) {} BranchDisplayDelegate(CodeViewWidget* parent) : QStyledItemDelegate(parent), m_parent(parent) {}
private: private:
CodeViewWidget* m_parent; CodeViewWidget* m_parent;