ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove DVDInterface::ChangeDiscAsHost 

There isn't much point in keeping this utility function around
now that RunAsCPUThread provides a simple way of running things
on the CPU thread.
This commit is contained in:
JosJuice 2017-09-17 11:12:02 +02:00
parent 29bfdbb36b
commit b6bc3bc7c9
7 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Source/Core/Core/HW/DVD/DVDInterface.cpp
View File

@ -19,7 +19,6 @@
#include "Common/Logging/Log.h"
#include "Core/ConfigManager.h"
#include "Core/Core.h"
#include "Core/CoreTiming.h"
#include "Core/HW/AudioInterface.h"
#include "Core/HW/DVD/DVDMath.h"
@ -473,14 +472,8 @@ static void InsertDiscCallback(u64 userdata, s64 cyclesLate)
s_disc_path_to_insert.clear();
}
// Can only be called by the host thread
void ChangeDiscAsHost(const std::string& new_path)
{
Core::RunAsCPUThread([&] { ChangeDiscAsCPU(new_path); });
}
// Can only be called by the CPU thread
void ChangeDiscAsCPU(const std::string& new_path)
// Must only be called on the CPU thread
void ChangeDisc(const std::string& new_path)
{
if (!s_disc_path_to_insert.empty())
{

3
Source/Core/Core/HW/DVD/DVDInterface.h
View File

@ -113,8 +113,7 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base);
void SetDisc(std::unique_ptr<DiscIO::Volume> disc);
bool IsDiscInside();
void ChangeDiscAsHost(const std::string& new_path); // Can only be called by the host thread
void ChangeDiscAsCPU(const std::string& new_path); // Can only be called by the CPU thread
void ChangeDisc(const std::string& new_path); // Must only be called on the CPU thread
// This function returns true and calls SConfig::SetRunningGameMetadata(Volume&, Partition&)
// if both of the following conditions are true:

2
Source/Core/Core/Movie.cpp
View File

@ -1180,7 +1180,7 @@ void PlayController(GCPadStatus* PadStatus, int controllerID)
}
if (found)
{
DVDInterface::ChangeDiscAsCPU(path);
Core::RunAsCPUThread([&path] { DVDInterface::ChangeDisc(path); });
}
else
{

3
Source/Core/DolphinQt2/GameList/GameList.cpp
View File

@ -417,7 +417,8 @@ void GameList::DeleteFile()
void GameList::ChangeDisc()
{
DVDInterface::ChangeDiscAsHost(GetSelectedGame()->GetFilePath().toStdString());
Core::RunAsCPUThread(
[this] { DVDInterface::ChangeDisc(GetSelectedGame()->GetFilePath().toStdString()); });
}
QSharedPointer<GameFile> GameList::GetSelectedGame() const

2
Source/Core/DolphinWX/Frame.cpp
View File

@ -143,7 +143,7 @@ void CRenderFrame::OnDropFiles(wxDropFilesEvent& event)
}
else
{
DVDInterface::ChangeDiscAsHost(filepath);
Core::RunAsCPUThread([&filepath] { DVDInterface::ChangeDisc(filepath); });
}
}

2
Source/Core/DolphinWX/FrameTools.cpp
View File

@ -369,7 +369,7 @@ void CFrame::DoOpen(bool Boot)
}
else
{
DVDInterface::ChangeDiscAsHost(WxStrToStr(path));
Core::RunAsCPUThread([&path] { DVDInterface::ChangeDisc(WxStrToStr(path)); });
}
}

2
Source/Core/DolphinWX/GameListCtrl.cpp
View File

@ -1557,7 +1557,7 @@ void GameListCtrl::OnChangeDisc(wxCommandEvent& WXUNUSED(event))
const GameListItem* iso = GetSelectedISO();
if (!iso || !Core::IsRunning())
return;
DVDInterface::ChangeDiscAsHost(WxStrToStr(iso->GetFileName()));
Core::RunAsCPUThread([&iso] { DVDInterface::ChangeDisc(WxStrToStr(iso->GetFileName())); });
}
void GameListCtrl::OnSize(wxSizeEvent& event)