ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

JitArm64: Fix rlwinmx. 

Seems like I was wrong that ANDI2R doesn't require a temporary register here.
There is *one* case when the mask won't fit in the ARM AND instruction:
mask = 0xFFFFFFFF
But let's just use MOV instead of AND here for this case...
This commit is contained in:
degasus 2017-08-22 08:47:43 +02:00
parent 9cdf4b5eaa
commit b00c60618b
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/Common/Arm64Emitter.cpp
View File

@ -4057,7 +4057,7 @@ void ARM64XEmitter::ANDI2R(ARM64Reg Rd, ARM64Reg Rn, u64 imm, ARM64Reg scratch)
else else
{ {
_assert_msg_(DYNA_REC, scratch != INVALID_REG, _assert_msg_(DYNA_REC, scratch != INVALID_REG,
"ANDSI2R - failed to construct logical immediate value from %08x, need scratch", "ANDI2R - failed to construct logical immediate value from %08x, need scratch",
(u32)imm); (u32)imm);
MOVI2R(scratch, imm); MOVI2R(scratch, imm);
AND(Rd, Rn, scratch); AND(Rd, Rn, scratch);

7
Source/Core/Core/PowerPC/JitArm64/JitArm64_Integer.cpp
View File

@ -532,7 +532,12 @@ void JitArm64::rlwinmx(UGeckoInstruction inst)
gpr.BindToRegister(a, a == s); gpr.BindToRegister(a, a == s);
if (!inst.SH) if (!inst.SH && mask == 0xFFFFFFFF)
{
if (a != s)
MOV(gpr.R(a), gpr.R(s));
}
else if (!inst.SH)
{ {
// Immediate mask // Immediate mask
ANDI2R(gpr.R(a), gpr.R(s), mask); ANDI2R(gpr.R(a), gpr.R(s), mask);