ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GameListModel: Don't do a linear scan for each newly added game

This commit is contained in:
JosJuice 2018-05-26 19:58:56 +02:00
parent e9ce75ccc4
commit a81a0d8c3e
4 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Source/Core/DolphinQt2/GameList/GameListModel.cpp
View File

@ -17,7 +17,8 @@ const QSize GAMECUBE_BANNER_SIZE(96, 32);
GameListModel::GameListModel(QObject* parent) : QAbstractTableModel(parent) GameListModel::GameListModel(QObject* parent) : QAbstractTableModel(parent)
{ {
connect(&m_tracker, &GameTracker::GameLoaded, this, &GameListModel::UpdateGame); connect(&m_tracker, &GameTracker::GameLoaded, this, &GameListModel::AddGame);
connect(&m_tracker, &GameTracker::GameUpdated, this, &GameListModel::UpdateGame);
connect(&m_tracker, &GameTracker::GameRemoved, this, &GameListModel::RemoveGame); connect(&m_tracker, &GameTracker::GameRemoved, this, &GameListModel::RemoveGame);
connect(&Settings::Instance(), &Settings::PathAdded, &m_tracker, &GameTracker::AddDirectory); connect(&Settings::Instance(), &Settings::PathAdded, &m_tracker, &GameTracker::AddDirectory);
connect(&Settings::Instance(), &Settings::PathRemoved, &m_tracker, &GameTracker::RemoveDirectory); connect(&Settings::Instance(), &Settings::PathRemoved, &m_tracker, &GameTracker::RemoveDirectory);
@ -218,14 +219,19 @@ std::shared_ptr<const UICommon::GameFile> GameListModel::GetGameFile(int index)
return m_games[index]; return m_games[index];
} }
void GameListModel::AddGame(const std::shared_ptr<const UICommon::GameFile>& game)
{
beginInsertRows(QModelIndex(), m_games.size(), m_games.size());
m_games.push_back(game);
endInsertRows();
}
void GameListModel::UpdateGame(const std::shared_ptr<const UICommon::GameFile>& game) void GameListModel::UpdateGame(const std::shared_ptr<const UICommon::GameFile>& game)
{ {
int index = FindGame(game->GetFilePath()); int index = FindGame(game->GetFilePath());
if (index < 0) if (index < 0)
{ {
beginInsertRows(QModelIndex(), m_games.size(), m_games.size()); AddGame(game);
m_games.push_back(game);
endInsertRows();
} }
else else
{ {

1
Source/Core/DolphinQt2/GameList/GameListModel.h
View File

@ -52,6 +52,7 @@ public:
NUM_COLS NUM_COLS
}; };
void AddGame(const std::shared_ptr<const UICommon::GameFile>& game);
void UpdateGame(const std::shared_ptr<const UICommon::GameFile>& game); void UpdateGame(const std::shared_ptr<const UICommon::GameFile>& game);
void RemoveGame(const std::string& path); void RemoveGame(const std::string& path);

11
Source/Core/DolphinQt2/GameList/GameTracker.cpp
View File

@ -89,15 +89,18 @@ void GameTracker::StartInternal()
for (const QString& path : m_tracked_files.keys()) for (const QString& path : m_tracked_files.keys())
paths.push_back(path.toStdString()); paths.push_back(path.toStdString());
auto emit_game_loaded = [this](const std::shared_ptr<const UICommon::GameFile>& game) { const auto emit_game_loaded = [this](const std::shared_ptr<const UICommon::GameFile>& game) {
emit GameLoaded(std::move(game)); emit GameLoaded(game);
}; };
auto emit_game_removed = [this](const std::string& path) { emit GameRemoved(path); }; const auto emit_game_updated = [this](const std::shared_ptr<const UICommon::GameFile>& game) {
emit GameUpdated(game);
};
const auto emit_game_removed = [this](const std::string& path) { emit GameRemoved(path); };
m_initial_games_emitted_event.Wait(); m_initial_games_emitted_event.Wait();
bool cache_updated = m_cache.Update(paths, emit_game_loaded, emit_game_removed); bool cache_updated = m_cache.Update(paths, emit_game_loaded, emit_game_removed);
cache_updated |= m_cache.UpdateAdditionalMetadata(m_title_database, emit_game_loaded); cache_updated |= m_cache.UpdateAdditionalMetadata(m_title_database, emit_game_updated);
if (cache_updated) if (cache_updated)
m_cache.Save(); m_cache.Save();
} }

3
Source/Core/DolphinQt2/GameList/GameTracker.h
View File

@ -39,7 +39,8 @@ public:
void ReloadDirectory(const QString& dir); void ReloadDirectory(const QString& dir);
signals: signals:
void GameLoaded(std::shared_ptr<const UICommon::GameFile> game); void GameLoaded(const std::shared_ptr<const UICommon::GameFile>& game);
void GameUpdated(const std::shared_ptr<const UICommon::GameFile>& game);
void GameRemoved(const std::string& path); void GameRemoved(const std::string& path);
private: private: