ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DSPHLE/UCodes: Replace unnecessary virtual keywords with override 

Given these HLE classes inherit from a common base with a virtual
destructor, override is more appropriate here, as virtual propagates to
these destructors anyway.

This is also safer. If the base class' destructor is ever made
non-virtual, then these classes will cause a compilation error if they
aren't taken into account, as they'd be overriding a non-virtual
function (the destructor).
This commit is contained in:
Lioncash 2018-05-16 15:57:12 -04:00
parent b203024a26
commit a7b8b15e7f
7 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/Core/HW/DSPHLE/UCodes/AX.h
View File

@ -59,7 +59,7 @@ class AXUCode : public UCodeInterface
{ {
public: public:
AXUCode(DSPHLE* dsphle, u32 crc); AXUCode(DSPHLE* dsphle, u32 crc);
virtual ~AXUCode(); ~AXUCode() override;
void Initialize() override; void Initialize() override;
void HandleMail(u32 mail) override; void HandleMail(u32 mail) override;

2
Source/Core/Core/HW/DSPHLE/UCodes/AXWii.h
View File

@ -18,7 +18,7 @@ class AXWiiUCode : public AXUCode
{ {
public: public:
AXWiiUCode(DSPHLE* dsphle, u32 crc); AXWiiUCode(DSPHLE* dsphle, u32 crc);
virtual ~AXWiiUCode(); ~AXWiiUCode() override;
void DoState(PointerWrap& p) override; void DoState(PointerWrap& p) override;

2
Source/Core/Core/HW/DSPHLE/UCodes/CARD.h
View File

@ -17,7 +17,7 @@ class CARDUCode : public UCodeInterface
{ {
public: public:
CARDUCode(DSPHLE* dsphle, u32 crc); CARDUCode(DSPHLE* dsphle, u32 crc);
virtual ~CARDUCode(); ~CARDUCode() override;
void Initialize() override; void Initialize() override;
void HandleMail(u32 mail) override; void HandleMail(u32 mail) override;

2
Source/Core/Core/HW/DSPHLE/UCodes/GBA.h
View File

@ -21,7 +21,7 @@ void ProcessGBACrypto(u32 address);
struct GBAUCode : public UCodeInterface struct GBAUCode : public UCodeInterface
{ {
GBAUCode(DSPHLE* dsphle, u32 crc); GBAUCode(DSPHLE* dsphle, u32 crc);
virtual ~GBAUCode(); ~GBAUCode() override;
void Initialize() override; void Initialize() override;
void HandleMail(u32 mail) override; void HandleMail(u32 mail) override;

2
Source/Core/Core/HW/DSPHLE/UCodes/INIT.h
View File

@ -17,7 +17,7 @@ class INITUCode : public UCodeInterface
{ {
public: public:
INITUCode(DSPHLE* dsphle, u32 crc); INITUCode(DSPHLE* dsphle, u32 crc);
virtual ~INITUCode(); ~INITUCode() override;
void Initialize() override; void Initialize() override;
void HandleMail(u32 mail) override; void HandleMail(u32 mail) override;

2
Source/Core/Core/HW/DSPHLE/UCodes/ROM.h
View File

@ -17,7 +17,7 @@ class ROMUCode : public UCodeInterface
{ {
public: public:
ROMUCode(DSPHLE* dsphle, u32 crc); ROMUCode(DSPHLE* dsphle, u32 crc);
virtual ~ROMUCode(); ~ROMUCode() override;
void Initialize() override; void Initialize() override;
void HandleMail(u32 mail) override; void HandleMail(u32 mail) override;

2
Source/Core/Core/HW/DSPHLE/UCodes/Zelda.h
View File

@ -194,7 +194,7 @@ class ZeldaUCode : public UCodeInterface
{ {
public: public:
ZeldaUCode(DSPHLE* dsphle, u32 crc); ZeldaUCode(DSPHLE* dsphle, u32 crc);
virtual ~ZeldaUCode(); ~ZeldaUCode() override;
void Initialize() override; void Initialize() override;
void HandleMail(u32 mail) override; void HandleMail(u32 mail) override;