ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10107 from OatmealDome/amd-subgroup-reduction 

VulkanContext: Disable subgroup reduction on Macs with AMD GPUs
This commit is contained in:
JosJuice 2021-09-17 16:19:58 +02:00 committed by GitHub
parent 2d1ec6332b 7e8f5208fe
commit a6baca6bf6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/VideoBackends/Vulkan/VulkanContext.cpp
View File

@ -944,7 +944,8 @@ void VulkanContext::PopulateShaderSubgroupSupport()
VK_SUBGROUP_FEATURE_BALLOT_BIT; VK_SUBGROUP_FEATURE_BALLOT_BIT;
m_supports_shader_subgroup_operations = m_supports_shader_subgroup_operations =
(subgroup_properties.supportedOperations & required_operations) == required_operations && (subgroup_properties.supportedOperations & required_operations) == required_operations &&
subgroup_properties.supportedStages & VK_SHADER_STAGE_FRAGMENT_BIT; subgroup_properties.supportedStages & VK_SHADER_STAGE_FRAGMENT_BIT &&
!DriverDetails::HasBug(DriverDetails::BUG_BROKEN_SUBGROUP_INVOCATION_ID);
} }
bool VulkanContext::SupportsExclusiveFullscreen(const WindowSystemInfo& wsi, VkSurfaceKHR surface) bool VulkanContext::SupportsExclusiveFullscreen(const WindowSystemInfo& wsi, VkSurfaceKHR surface)

2
Source/Core/VideoCommon/DriverDetails.cpp
View File

@ -127,6 +127,8 @@ constexpr BugInfo m_known_bugs[] = {
-1.0, -1.0, true}, -1.0, -1.0, true},
{API_OPENGL, OS_WINDOWS, VENDOR_ATI, DRIVER_ATI, Family::UNKNOWN, BUG_BROKEN_SSBO_FIELD_ATOMICS, {API_OPENGL, OS_WINDOWS, VENDOR_ATI, DRIVER_ATI, Family::UNKNOWN, BUG_BROKEN_SSBO_FIELD_ATOMICS,
-1.0, -1.0, true}, -1.0, -1.0, true},
{API_VULKAN, OS_OSX, VENDOR_ATI, DRIVER_PORTABILITY, Family::UNKNOWN,
BUG_BROKEN_SUBGROUP_INVOCATION_ID, -1.0, -1.0, true},
}; };
static std::map<Bug, BugInfo> m_bugs; static std::map<Bug, BugInfo> m_bugs;

6
Source/Core/VideoCommon/DriverDetails.h
View File

@ -305,6 +305,12 @@ enum Bug
// Started version: -1 // Started version: -1
// Ended version: -1 // Ended version: -1
BUG_BROKEN_SSBO_FIELD_ATOMICS, BUG_BROKEN_SSBO_FIELD_ATOMICS,
// BUG: Accessing gl_SubgroupInvocationID causes the Metal shader compiler to crash.
// Affected devices: AMD (macOS)
// Started version: -1
// Ended version: -1
BUG_BROKEN_SUBGROUP_INVOCATION_ID,
}; };
// Initializes our internal vendor, device family, and driver version // Initializes our internal vendor, device family, and driver version