From a5297f6da8fbe365b2d2210d9c15b34d0fe2f3f3 Mon Sep 17 00:00:00 2001 From: "Jasper St. Pierre" Date: Sat, 12 Jul 2014 11:21:41 -0400 Subject: [PATCH] PixelEngine: Remove unused AllowIdleSkipping and all references to it --- .../Interpreter/Interpreter_LoadStore.cpp | 16 ---------------- Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp | 1 - Source/Core/VideoCommon/CommandProcessor.h | 2 -- 3 files changed, 19 deletions(-) diff --git a/Source/Core/Core/PowerPC/Interpreter/Interpreter_LoadStore.cpp b/Source/Core/Core/PowerPC/Interpreter/Interpreter_LoadStore.cpp index fc04cbfb9b..d78b1626d5 100644 --- a/Source/Core/Core/PowerPC/Interpreter/Interpreter_LoadStore.cpp +++ b/Source/Core/Core/PowerPC/Interpreter/Interpreter_LoadStore.cpp @@ -220,22 +220,6 @@ void Interpreter::lwz(UGeckoInstruction _inst) { m_GPR[_inst.RD] = temp; } - - // hack to detect SelectThread loop - // should probably run a pass through memory instead before execution - // but that would be dangerous - - // Enable idle skipping? - /* - if ((_inst.hex & 0xFFFF0000)==0x800D0000 && - Memory::ReadUnchecked_U32(PC+4)==0x28000000 && - Memory::ReadUnchecked_U32(PC+8)==0x4182fff8) - { - if (CommandProcessor::AllowIdleSkipping() && PixelEngine::AllowIdleSkipping()) - { - CoreTiming::Idle(); - } - }*/ } void Interpreter::lwzu(UGeckoInstruction _inst) diff --git a/Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp b/Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp index 142a5e2443..f085284ed8 100644 --- a/Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp +++ b/Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp @@ -94,7 +94,6 @@ void Jit64::lXXx(UGeckoInstruction inst) // (mb2): I agree, // IMHO those Idles should always be skipped and replaced by a more controllable "native" Idle methode // ... maybe the throttle one already do that :p - // if (CommandProcessor::AllowIdleSkipping() && PixelEngine::AllowIdleSkipping()) if (SConfig::GetInstance().m_LocalCoreStartupParameter.bSkipIdle && inst.OPCD == 32 && (inst.hex & 0xFFFF0000) == 0x800D0000 && diff --git a/Source/Core/VideoCommon/CommandProcessor.h b/Source/Core/VideoCommon/CommandProcessor.h index a70c30fb36..5ad8e19562 100644 --- a/Source/Core/VideoCommon/CommandProcessor.h +++ b/Source/Core/VideoCommon/CommandProcessor.h @@ -141,8 +141,6 @@ void GatherPipeBursted(); void UpdateInterrupts(u64 userdata); void UpdateInterruptsFromVideoBackend(u64 userdata); -bool AllowIdleSkipping(); - void SetCpClearRegister(); void SetCpControlRegister(); void SetCpStatusRegister();