From 9955a06dbd7effb451a67e09720222fac8ba9601 Mon Sep 17 00:00:00 2001 From: Dentomologist Date: Sat, 12 Aug 2023 12:53:57 -0700 Subject: [PATCH] NandPaths: Resolve Android tautological comparison warning Android interprets char as unsigned char, so comparing with 0 triggers a tautological-unsigned-char-zero-compare warning. Casting c to an unsigned char and removing the comparison with 0 resolves the warning while needing one less comparison on all platforms. --- Source/Core/Common/NandPaths.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Common/NandPaths.cpp b/Source/Core/Common/NandPaths.cpp index c9217565bb..e6f2d2a88b 100644 --- a/Source/Core/Common/NandPaths.cpp +++ b/Source/Core/Common/NandPaths.cpp @@ -107,7 +107,7 @@ static bool IsIllegalCharacter(char c) { static const std::unordered_set illegal_chars = {'\"', '*', '/', ':', '<', '>', '?', '\\', '|', '\x7f'}; - return (c >= 0 && c <= 0x1F) || illegal_chars.find(c) != illegal_chars.end(); + return static_cast(c) <= 0x1F || illegal_chars.find(c) != illegal_chars.end(); } std::string EscapeFileName(const std::string& filename)