Clamp the AX Volume to prevent clipping. Patch by hk.konpie. Fixes issue 7519.

This commit is contained in:
skidau 2014-10-19 21:20:33 +11:00
parent 033a349444
commit 990697bcbb
1 changed files with 2 additions and 1 deletions

View File

@ -430,6 +430,7 @@ void MixAdd(int* out, const s16* input, u32 count, u16* pvol, s16* dpop, bool ra
s64 sample = input[i]; s64 sample = input[i];
sample *= volume; sample *= volume;
sample >>= 15; sample >>= 15;
sample = MathUtil::Clamp((s32)sample, -32767, 32767); // -32768 ?
out[i] += (s16)sample; out[i] += (s16)sample;
volume += volume_delta; volume += volume_delta;
@ -462,7 +463,7 @@ void ProcessVoice(PB_TYPE& pb, const AXBuffers& buffers, u16 count, AXMixControl
// Apply a global volume ramp using the volume envelope parameters. // Apply a global volume ramp using the volume envelope parameters.
for (u32 i = 0; i < count; ++i) for (u32 i = 0; i < count; ++i)
{ {
samples[i] = ((s32)samples[i] * pb.vol_env.cur_volume) >> 15; samples[i] = MathUtil::Clamp(((s32)samples[i] * pb.vol_env.cur_volume) >> 15, -32767, 32767); // -32768 ?
pb.vol_env.cur_volume += pb.vol_env.cur_volume_delta; pb.vol_env.cur_volume += pb.vol_env.cur_volume_delta;
} }