From 9245210c49f76856a30ea8bb077d97a8af0ee711 Mon Sep 17 00:00:00 2001 From: Michael M Date: Wed, 20 Sep 2017 09:33:52 -0700 Subject: [PATCH] Qt: bold graphics settings on ConfigChanged, not EmulationStateChanged EmulationStateChanged is functionally correct right now, but ConfigChanged expresses more semantically why the config setting gets re-read and the widgets updated. --- Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp | 2 +- Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp | 2 +- Source/Core/DolphinQt2/Config/Graphics/GraphicsSlider.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp b/Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp index 25d390be19..c6aacd3d72 100644 --- a/Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp +++ b/Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp @@ -16,7 +16,7 @@ GraphicsBool::GraphicsBool(const QString& label, const Config::ConfigInfo& connect(this, &QCheckBox::toggled, this, &GraphicsBool::Update); setChecked(Config::Get(m_setting) ^ reverse); - connect(&Settings::Instance(), &Settings::EmulationStateChanged, [this]() { + connect(&Settings::Instance(), &Settings::ConfigChanged, [this] { QFont bf = font(); bf.setBold(Config::GetActiveLayerForConfig(m_setting) != Config::LayerType::Base); setFont(bf); diff --git a/Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp b/Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp index 76655bb350..7199b2302c 100644 --- a/Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp +++ b/Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp @@ -15,7 +15,7 @@ GraphicsChoice::GraphicsChoice(const QStringList& options, const Config::ConfigI &GraphicsChoice::Update); setCurrentIndex(Config::Get(m_setting)); - connect(&Settings::Instance(), &Settings::EmulationStateChanged, [this]() { + connect(&Settings::Instance(), &Settings::ConfigChanged, [this] { QFont bf = font(); bf.setBold(Config::GetActiveLayerForConfig(m_setting) != Config::LayerType::Base); setFont(bf); diff --git a/Source/Core/DolphinQt2/Config/Graphics/GraphicsSlider.cpp b/Source/Core/DolphinQt2/Config/Graphics/GraphicsSlider.cpp index 0e40e4164d..4561aa22eb 100644 --- a/Source/Core/DolphinQt2/Config/Graphics/GraphicsSlider.cpp +++ b/Source/Core/DolphinQt2/Config/Graphics/GraphicsSlider.cpp @@ -19,7 +19,7 @@ GraphicsSlider::GraphicsSlider(int minimum, int maximum, const Config::ConfigInf connect(this, &GraphicsSlider::valueChanged, this, &GraphicsSlider::Update); - connect(&Settings::Instance(), &Settings::EmulationStateChanged, [this]() { + connect(&Settings::Instance(), &Settings::ConfigChanged, [this] { QFont bf = font(); bf.setBold(Config::GetActiveLayerForConfig(m_setting) != Config::LayerType::Base); setFont(bf);