ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DSPEmitter: Make member functions, aliases and constants private where applicable 

Given we now use a base class for the interface, we can make all member
functions, types and constants that aren't directly related to
instructions private.
This commit is contained in:
Lioncash 2018-06-21 13:42:56 -04:00
parent 77f6e50493
commit 8d9f74b762
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
Source/Core/Core/DSP/Jit/x64/DSPEmitter.h
View File

@ -28,11 +28,6 @@ namespace JIT::x64
class DSPEmitter final : public JIT::DSPEmitter, public Gen::X64CodeBlock class DSPEmitter final : public JIT::DSPEmitter, public Gen::X64CodeBlock
{ {
public: public:
using DSPCompiledCode = u32 (*)();
using Block = const u8*;
static constexpr size_t MAX_BLOCKS = 0x10000;
DSPEmitter(); DSPEmitter();
~DSPEmitter() override; ~DSPEmitter() override;
@ -40,17 +35,6 @@ public:
void DoState(PointerWrap& p) override; void DoState(PointerWrap& p) override;
void ClearIRAM() override; void ClearIRAM() override;
void EmitInstruction(UDSPInstruction inst);
void ClearIRAMandDSPJITCodespaceReset();
void CompileDispatcher();
Block CompileStub();
void Compile(u16 start_addr);
bool FlagsNeeded() const;
void FallBackToInterpreter(UDSPInstruction inst);
// Ext commands // Ext commands
void l(UDSPInstruction opc); void l(UDSPInstruction opc);
void ln(UDSPInstruction opc); void ln(UDSPInstruction opc);
@ -206,10 +190,24 @@ public:
void msub(UDSPInstruction opc); void msub(UDSPInstruction opc);
private: private:
using DSPCompiledCode = u32 (*)();
using Block = const u8*;
// The emitter emits calls to this function. It's present here // The emitter emits calls to this function. It's present here
// within the class itself to allow access to member variables. // within the class itself to allow access to member variables.
static void CompileCurrent(DSPEmitter& emitter); static void CompileCurrent(DSPEmitter& emitter);
void EmitInstruction(UDSPInstruction inst);
void ClearIRAMandDSPJITCodespaceReset();
void CompileDispatcher();
Block CompileStub();
void Compile(u16 start_addr);
bool FlagsNeeded() const;
void FallBackToInterpreter(UDSPInstruction inst);
void WriteBranchExit(); void WriteBranchExit();
void WriteBlockLink(u16 dest); void WriteBlockLink(u16 dest);
@ -298,6 +296,8 @@ private:
void multiply_sub(); void multiply_sub();
void multiply_mulx(u8 axh0, u8 axh1); void multiply_mulx(u8 axh0, u8 axh1);
static constexpr size_t MAX_BLOCKS = 0x10000;
DSPJitRegCache m_gpr{*this}; DSPJitRegCache m_gpr{*this};
u16 m_compile_pc; u16 m_compile_pc;