From 8c82607c957351877d3c4cc92e63b01c7c002b0c Mon Sep 17 00:00:00 2001
From: Florent Castelli <florent.castelli@gmail.com>
Date: Wed, 8 Feb 2017 02:57:36 +0100
Subject: [PATCH] cmake: Don't use unqualified target_link_libraries

You can't mix unqualified and qualified link libraries (PUBLIC / PRIVATE).
Use the modern form.
---
 Source/CMakeLists.txt                           | 2 +-
 Source/Core/VideoBackends/Vulkan/CMakeLists.txt | 2 +-
 Source/Core/VideoCommon/CMakeLists.txt          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Source/CMakeLists.txt b/Source/CMakeLists.txt
index e1836da317..b6a6fef1e4 100644
--- a/Source/CMakeLists.txt
+++ b/Source/CMakeLists.txt
@@ -21,7 +21,7 @@ add_definitions(-D__STDC_CONSTANT_MACROS)
 
 macro(add_dolphin_library lib srcs libs)
 	add_library(${lib} STATIC ${srcs})
-	target_link_libraries(${lib} ${libs})
+	target_link_libraries(${lib} PUBLIC ${libs})
 endmacro()
 
 add_subdirectory(Core)
diff --git a/Source/Core/VideoBackends/Vulkan/CMakeLists.txt b/Source/Core/VideoBackends/Vulkan/CMakeLists.txt
index fc5ac99df9..5df1876bfd 100644
--- a/Source/Core/VideoBackends/Vulkan/CMakeLists.txt
+++ b/Source/Core/VideoBackends/Vulkan/CMakeLists.txt
@@ -37,5 +37,5 @@ include_directories(SYSTEM ${CMAKE_SOURCE_DIR}/Externals/glslang/SPIRV)
 
 # Link against glslang, the other necessary libraries are referenced by the executable.
 add_dolphin_library(videovulkan "${SRCS}" "${LIBS}")
-target_link_libraries(videovulkan glslang)
+target_link_libraries(videovulkan PRIVATE glslang)
 
diff --git a/Source/Core/VideoCommon/CMakeLists.txt b/Source/Core/VideoCommon/CMakeLists.txt
index cb9bc61720..b7138ec6df 100644
--- a/Source/Core/VideoCommon/CMakeLists.txt
+++ b/Source/Core/VideoCommon/CMakeLists.txt
@@ -62,5 +62,5 @@ endif()
 add_dolphin_library(videocommon "${SRCS}" "${LIBS}")
 
 if(LIBAV_FOUND)
-	target_link_libraries(videocommon ${LIBS} ${LIBAV_LIBRARIES})
+	target_link_libraries(videocommon PRIVATE ${LIBS} ${LIBAV_LIBRARIES})
 endif()