From 0478ce72f5e0e70770c0ae6737f167169b08bc08 Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Thu, 5 Mar 2020 21:00:28 +0000 Subject: [PATCH 1/2] Source/Core/Common/StringUtil.h: include for std::numeric_limits Without included header build fails on gcc-10 as: ``` [ 13%] Building CXX object Source/Core/AudioCommon/CMakeFiles/audiocommon.dir/CubebUtils.cpp.o In file included from ../../../../Source/Core/AudioCommon/CubebUtils.cpp:13: ../../../../Source/Core/Common/StringUtil.h: In function 'bool TryParse(const string&, T*)': ../../../../Source/Core/Common/StringUtil.h:84:20: error: 'numeric_limits' is not a member of 'std' 84 | if (value < std::numeric_limits::min() || | ^~~~~~~~~~~~~~ ``` Signed-off-by: Sergei Trofimovich --- Source/Core/Common/StringUtil.h | 1 + 1 file changed, 1 insertion(+) diff --git a/Source/Core/Common/StringUtil.h b/Source/Core/Common/StringUtil.h index 93199917b9..211c381abf 100644 --- a/Source/Core/Common/StringUtil.h +++ b/Source/Core/Common/StringUtil.h @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include From 879e8364af5db9488d5ec6ea635ef0dfa42b54ef Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Thu, 5 Mar 2020 21:06:27 +0000 Subject: [PATCH 2/2] Source/Core/Core/DSP/DSPTables.cpp: include for sprintf Without included header build fails on gcc-10 as: ``` [ 52%] Building CXX object Source/Core/Core/CMakeFiles/core.dir/DSP/DSPTables.cpp.o ../../../../Source/Core/Core/DSP/DSPTables.cpp: In function 'const char* DSP::pdname(u16)': ../../../../Source/Core/Core/DSP/DSPTables.cpp:492:3: error: 'sprintf' was not declared in this scope 492 | sprintf(tmpstr, "0x%04x", val); | ^~~~~~~ ``` Signed-off-by: Sergei Trofimovich --- Source/Core/Core/DSP/DSPTables.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Source/Core/Core/DSP/DSPTables.cpp b/Source/Core/Core/DSP/DSPTables.cpp index 30deea113f..fab99f42e6 100644 --- a/Source/Core/Core/DSP/DSPTables.cpp +++ b/Source/Core/Core/DSP/DSPTables.cpp @@ -9,6 +9,7 @@ #include #include #include +#include #include "Common/CommonTypes.h" #include "Common/Logging/Log.h"