ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10645 from shuffle2/qt-hack 

qt/win: remove hack for tab bar scroll buttons
This commit is contained in:
Tilka 2022-05-09 19:27:25 +01:00 committed by GitHub
parent b339c6cac1 5d459380d1
commit 866a8da3ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Source/Core/DolphinQt/Settings.cpp
View File

@ -155,22 +155,6 @@ void Settings::SetCurrentUserStyle(const QString& stylesheet_name)
.arg(border_color.rgba(), 0, 16);
stylesheet_contents.append(QStringLiteral("%1").arg(tooltip_stylesheet));
}
#ifdef _WIN32
// MSVC has a bug causing QTabBar scroll buttons to be partially transparent when they inherit any
// stylesheet (see https://bugreports.qt.io/browse/QTBUG-74187) which is triggered when setting
// qApp's stylesheet below. Setting the scroll buttons' color directly fixes the problem.
// Create a temporary QToolButton that's a child of a QTabBar in case that has different styling
// than a plain QToolButton.
const auto tab_bar = std::make_unique<QTabBar>();
auto* const tool_button = new QToolButton(tab_bar.get());
const QRgb background_color = tool_button->palette().color(QPalette::Button).rgba();
const std::string style_var =
fmt::format("QTabBar QToolButton {{ background-color: #{:08x}; }}", background_color);
stylesheet_contents.append(QString::fromStdString(style_var));
#endif
qApp->setStyleSheet(stylesheet_contents);