From 86000fc6b4531123adb2cffa46fffae5ebfe425d Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sat, 27 Jul 2019 16:03:55 -0400 Subject: [PATCH] VideoBackends/Null: Remove unnecessary constructors and destructors Removes constructors and destructors that don't actually provide any behavior (i.e. doesn't constain generated code related to non-trivial members in a cpp file, etc). Lessens the amount of code present. --- Source/Core/VideoBackends/Null/NullTexture.h | 2 -- Source/Core/VideoBackends/Null/PerfQuery.h | 2 -- Source/Core/VideoBackends/Null/Render.cpp | 4 ---- Source/Core/VideoBackends/Null/TextureCache.h | 4 ---- 4 files changed, 12 deletions(-) diff --git a/Source/Core/VideoBackends/Null/NullTexture.h b/Source/Core/VideoBackends/Null/NullTexture.h index 42cbc7e542..ce3726be0f 100644 --- a/Source/Core/VideoBackends/Null/NullTexture.h +++ b/Source/Core/VideoBackends/Null/NullTexture.h @@ -19,7 +19,6 @@ class NullTexture final : public AbstractTexture { public: explicit NullTexture(const TextureConfig& config); - ~NullTexture() = default; void CopyRectangleFromTexture(const AbstractTexture* src, const MathUtil::Rectangle& src_rect, u32 src_layer, @@ -58,7 +57,6 @@ public: explicit NullFramebuffer(AbstractTexture* color_attachment, AbstractTexture* depth_attachment, AbstractTextureFormat color_format, AbstractTextureFormat depth_format, u32 width, u32 height, u32 layers, u32 samples); - ~NullFramebuffer() override = default; static std::unique_ptr Create(NullTexture* color_attachment, NullTexture* depth_attachment); diff --git a/Source/Core/VideoBackends/Null/PerfQuery.h b/Source/Core/VideoBackends/Null/PerfQuery.h index 91d13d4722..80e33753ba 100644 --- a/Source/Core/VideoBackends/Null/PerfQuery.h +++ b/Source/Core/VideoBackends/Null/PerfQuery.h @@ -11,8 +11,6 @@ namespace Null class PerfQuery : public PerfQueryBase { public: - PerfQuery() {} - ~PerfQuery() override {} void EnableQuery(PerfQueryGroup type) override {} void DisableQuery(PerfQueryGroup type) override {} void ResetQuery() override {} diff --git a/Source/Core/VideoBackends/Null/Render.cpp b/Source/Core/VideoBackends/Null/Render.cpp index cfa35c7315..7e8719baf5 100644 --- a/Source/Core/VideoBackends/Null/Render.cpp +++ b/Source/Core/VideoBackends/Null/Render.cpp @@ -44,7 +44,6 @@ class NullShader final : public AbstractShader { public: explicit NullShader(ShaderStage stage) : AbstractShader(stage) {} - ~NullShader() = default; }; std::unique_ptr @@ -61,9 +60,6 @@ std::unique_ptr Renderer::CreateShaderFromBinary(ShaderStage sta class NullPipeline final : public AbstractPipeline { -public: - NullPipeline() = default; - ~NullPipeline() override = default; }; std::unique_ptr Renderer::CreatePipeline(const AbstractPipelineConfig& config, diff --git a/Source/Core/VideoBackends/Null/TextureCache.h b/Source/Core/VideoBackends/Null/TextureCache.h index b9dd2de90a..7688004da2 100644 --- a/Source/Core/VideoBackends/Null/TextureCache.h +++ b/Source/Core/VideoBackends/Null/TextureCache.h @@ -10,10 +10,6 @@ namespace Null { class TextureCache : public TextureCacheBase { -public: - TextureCache() {} - ~TextureCache() {} - protected: void CopyEFB(AbstractStagingTexture* dst, const EFBCopyParams& params, u32 native_width, u32 bytes_per_row, u32 num_blocks_y, u32 memory_stride,