ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

StringUtil: Remove ValueToString(std::string) 

Doesn't make a lot of sense to have a function that gives the string
representation for a string.
This commit is contained in:
Léo Lam 2018-06-03 14:55:39 +02:00
parent 7e79bf97ab
commit 83324fe77d
3 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/Common/Config/Layer.h
View File

@ -120,13 +120,17 @@ public:
template <typename T> template <typename T>
void Set(const ConfigInfo<T>& config_info, const std::common_type_t<T>& value) void Set(const ConfigInfo<T>& config_info, const std::common_type_t<T>& value)
{ {
Set<T>(config_info.location, value); Set(config_info.location, value);
} }
template <typename T> template <typename T>
void Set(const ConfigLocation& location, const T& value) void Set(const ConfigLocation& location, const T& value)
{ {
const std::string new_value = ValueToString(value); Set(location, ValueToString(value));
}
void Set(const ConfigLocation& location, const std::string& new_value)
{
std::optional<std::string>& current_value = m_map[location]; std::optional<std::string>& current_value = m_map[location];
if (current_value == new_value) if (current_value == new_value)
return; return;

5
Source/Core/Common/StringUtil.cpp
View File

@ -332,11 +332,6 @@ std::string ValueToString(bool value)
return value ? "True" : "False"; return value ? "True" : "False";
} }
std::string ValueToString(const std::string& value)
{
return value;
}
bool SplitPath(const std::string& full_path, std::string* _pPath, std::string* _pFilename, bool SplitPath(const std::string& full_path, std::string* _pPath, std::string* _pFilename,
std::string* _pExtension) std::string* _pExtension)
{ {

1
Source/Core/Common/StringUtil.h
View File

@ -90,7 +90,6 @@ std::string ValueToString(double value);
std::string ValueToString(int value); std::string ValueToString(int value);
std::string ValueToString(s64 value); std::string ValueToString(s64 value);
std::string ValueToString(bool value); std::string ValueToString(bool value);
std::string ValueToString(const std::string& value);
template <typename T, std::enable_if_t<std::is_enum<T>::value>* = nullptr> template <typename T, std::enable_if_t<std::is_enum<T>::value>* = nullptr>
std::string ValueToString(T value) std::string ValueToString(T value)
{ {