ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GraphicsModListWidget: Pass optional by const reference 

All we do is read from it, so we don't need to copy the string if we
happen to have one.
This commit is contained in:
Lioncash 2024-01-31 12:09:33 -05:00
parent a1879ea099
commit 81aca79145
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/DolphinQt/Config/GraphicsModListWidget.cpp
View File

@ -185,7 +185,7 @@ void GraphicsModListWidget::ModItemChanged(QListWidgetItem* item)
m_needs_save = true; m_needs_save = true;
} }
void GraphicsModListWidget::OnModChanged(std::optional<std::string> absolute_path) void GraphicsModListWidget::OnModChanged(const std::optional<std::string>& absolute_path)
{ {
ClearLayoutRecursively(m_mod_meta_layout); ClearLayoutRecursively(m_mod_meta_layout);
@ -198,7 +198,7 @@ void GraphicsModListWidget::OnModChanged(std::optional<std::string> absolute_pat
return; return;
} }
GraphicsModConfig* mod = m_mod_group.GetMod(*absolute_path); const GraphicsModConfig* mod = m_mod_group.GetMod(*absolute_path);
if (!mod) if (!mod)
return; return;

2
Source/Core/DolphinQt/Config/GraphicsModListWidget.h
View File

@ -52,7 +52,7 @@ private:
void ModSelectionChanged(); void ModSelectionChanged();
void ModItemChanged(QListWidgetItem* item); void ModItemChanged(QListWidgetItem* item);
void OnModChanged(std::optional<std::string> absolute_path); void OnModChanged(const std::optional<std::string>& absolute_path);
void SaveModList(); void SaveModList();