ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Android] Reenable the bug for dynamic UBO array member accesses. 

Some information on this bug since this isn't quite true.
Seemingly with the v53 driver, Qualcomm has actually fixed this bug. So we can dynamically access UBO array members.
The issue that is cropping up is actually converting our attribute 'fposmtx' to an integer.
int posmtx = int(fpostmtx);
This line causes some seemingly garbage values to enter in to the posmtx variable.
Not sure exactly why it is failing, probably them just not actually converting the float to an integer and just handling the float directly as a integer.
So the bug is going to stay active with Qualcomm devices until we convert this vertex attribute from a float to a integer.
This commit is contained in:
Ryan Houdek 2014-01-07 07:56:30 -06:00
parent 55717ed216
commit 7acc64eb0a
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/VideoCommon/DriverDetails.cpp
View File

@ -40,7 +40,7 @@ namespace DriverDetails
// This is a list of all known bugs for each vendor // This is a list of all known bugs for each vendor
// We use this to check if the device and driver has a issue // We use this to check if the device and driver has a issue
BugInfo m_known_bugs[] = { BugInfo m_known_bugs[] = {
{OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM_3XX, -1, BUG_NODYNUBOACCESS, 14.0, 46.0, true}, {OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM_3XX, -1, BUG_NODYNUBOACCESS, 14.0, -1.0, true},
{OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM_3XX, -1, BUG_BROKENCENTROID, 14.0, 46.0, true}, {OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM_3XX, -1, BUG_BROKENCENTROID, 14.0, 46.0, true},
{OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM_3XX, -1, BUG_BROKENINFOLOG, -1.0, 46.0, true}, {OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM_3XX, -1, BUG_BROKENINFOLOG, -1.0, 46.0, true},
{OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM_3XX, -1, BUG_ANNIHILATEDUBOS, 41.0, 46.0, true}, {OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM_3XX, -1, BUG_ANNIHILATEDUBOS, 41.0, 46.0, true},

5
Source/Core/VideoCommon/DriverDetails.h
View File

@ -65,6 +65,11 @@ namespace DriverDetails
// Ended Version: 53 // Ended Version: 53
// Accessing UBO array members dynamically causes the Adreno shader compiler to crash // Accessing UBO array members dynamically causes the Adreno shader compiler to crash
// Errors out with "Internal Error" // Errors out with "Internal Error"
// With v53 video drivers, dynamic member access works. But there is a new bug
// The only time we access UBO array members dynamically is with a conversion
// int posmtx = int(fposmtx);
// This line will will posmtx with a seemingly random number and cause issues.
// Bug still active with v53 until we switch to using integers for the fposmtx attribute
BUG_NODYNUBOACCESS = 0, BUG_NODYNUBOACCESS = 0,
// Bug: Centroid is broken in shaders // Bug: Centroid is broken in shaders
// Affected devices: Qualcomm/Adreno // Affected devices: Qualcomm/Adreno