From 02cd8b63630bc6fae9b208531d5b31a44572412a Mon Sep 17 00:00:00 2001 From: Pokechu22 Date: Fri, 7 Apr 2023 22:33:40 -0700 Subject: [PATCH] DolphinQt: Fix mouse lock checkbox appearing when it shouldn't See https://bugs.dolphin-emu.org/issues/13232; this was introduced in 7dde0c3c319577fd913e4de72a6113a8998ada49. Apparently, providing a parent for a widget that is not visible makes your new widget visible when the parent is later made visible, in addition to managing the deletion of the widget; the documentation does not specify this (only that if the parent is visible you need to explicitly show it). --- Source/Core/DolphinQt/Settings/InterfacePane.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Source/Core/DolphinQt/Settings/InterfacePane.cpp b/Source/Core/DolphinQt/Settings/InterfacePane.cpp index 9365795551..8cbcc62ee3 100644 --- a/Source/Core/DolphinQt/Settings/InterfacePane.cpp +++ b/Source/Core/DolphinQt/Settings/InterfacePane.cpp @@ -204,6 +204,8 @@ void InterfacePane::CreateInGame() groupbox_layout->addWidget(mouse_groupbox); #ifdef _WIN32 groupbox_layout->addWidget(m_checkbox_lock_mouse); +#else + m_checkbox_lock_mouse->hide(); #endif }